Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

UserAgentParser: misdetect Shiira and Safari #2099

Closed
robocoder opened this Issue · 1 comment

1 participant

Anthon Pang
Anthon Pang
Collaborator

Shiira 2.2 (a Japanese WebKit based browser) is misdetected as Safari 1.2 (which is actually the webkit version used by Safari 3.2.3)

  • Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; en-us) AppleWebKit/525.28.3 (KHTML, like Gecko) Shiira Safari/125

During my testing, I found Safari would sometimes (spurious, as I have difficulty reproducing) send a truncated User Agent, e.g.,

  • Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US) AppleWebKit/533.19.4 (KHTML, like Gecko)
Anthon Pang
Collaborator

(In [3950]) fixes #2099 - treat Shiira as Safari since Shiira uses the installed version of Safari's webkit; for truncated UA, use the AppleWebKit version for detection

Anthon Pang robocoder added this to the Piwik 1.2 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.