Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

UI: replace confirm() and alert() with jQuery-UI dialog #2123

Closed
robocoder opened this Issue · 9 comments

3 participants

@robocoder

Reference: http://jqueryui.com/demos/dialog/#modal-confirmation

This can be themed/styled and also workaround the Safari/WebKit bug mentioned in #1728.

See also: piwikHelper.windowModal().

@mattab
Owner

from #1490

The popover showing for Widget delete confirmation (see piwikHelper.windowModal JS) should be reused in other deletion confirmation such as

user deletion,
site deletion,
goal deletion 
@sgiehl
Collaborator

@vipsoft: are you still working on that item? If not, I would do so ;)

@robocoder

@SteveG thanks.

@sgiehl
Collaborator

(In [4641]) refs #2123

  • now using jquery.dialog for existing modal confirms
  • replaced js confirm for user deletion with new dialog confirm
  • remove inclusion of jquery blockUI and bgiFrame, as not needed anymore (btw. bgiFrame causes script error in IE 9)
  • fixed some IE 7/8 issues tested in IE 7/8/9, FF 3.6, Chrome and Safari/Win
@mattab
Owner

Last 2 items are:

  • Goals deletion use the dialog
  • Website deletion use the dialog

Kuddos Stefan for reducing our technical debt!

@sgiehl
Collaborator

(In [4647]) refs #2123 replaced js confirm with dialog for goal deletion

@sgiehl
Collaborator

(In [4648]) refs #2123 replaced last confirm with dialog (site deletion)

@sgiehl
Collaborator

(In [4650]) fixes #2123 replaced js alerts with jquery dialogs

@sgiehl
Collaborator

(In [4658]) refs #2123 deleted now unused jquery files

@robocoder robocoder added this to the 1.5 - Piwik 1.5 milestone
@sgiehl sgiehl was assigned by robocoder
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.