Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

LanguagesManager.test.php, TranslationsAdmin, and tidy script: refactor saveTranslation #2229

Closed
robocoder opened this Issue · 3 comments

2 participants

Anthon Pang Matthieu Aubry
Anthon Pang
Collaborator

None

Matthieu Aubry
Owner

not mandatory to refactor, since we always run the languagesmanager.test.php before release, so having all cleanup code in there is good enough I think

Anthon Pang
Collaborator

There are differences in the output when each saves the translations to a file. It makes sense to make these uniform through a single writer, to minimize diffs.

Anthon Pang
Collaborator

(In [4209]) fixes #2229, refs #5591 - TranslationWriter contains refactored saveTranslation code; also added unit tests

Anthon Pang robocoder added this to the Piwik 1.3 milestone
Anthon Pang robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.