LanguagesManager.test.php, TranslationsAdmin, and tidy script: refactor saveTranslation #2229

Closed
robocoder opened this Issue Mar 25, 2011 · 3 comments

2 participants

@robocoder

None

@mattab
Piwik Open Source Analytics member

not mandatory to refactor, since we always run the languagesmanager.test.php before release, so having all cleanup code in there is good enough I think

@robocoder

There are differences in the output when each saves the translations to a file. It makes sense to make these uniform through a single writer, to minimize diffs.

@robocoder

(In [4209]) fixes #2229, refs #5591 - TranslationWriter contains refactored saveTranslation code; also added unit tests

@robocoder robocoder added this to the Piwik 1.3 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment