Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Google advanced search not detected #2283

Closed
sgiehl opened this Issue · 2 comments

2 participants

Stefan Giehl Anthon Pang
Stefan Giehl
Collaborator

In one special case Google's advanced search is not detected correctly.

In [https://github.com/piwik/piwik/blob/master/core/Common.php#L1378] Google's advanced search params are handled. In case that the as_q parameter is the first argument of the query string that doesn't work. I guess an additional check for ?as_q should fix that issue.

Anthon Pang
Collaborator

(In [4371]) fixes #2283

Anthon Pang
Collaborator

(In [4481]) refs #2319, refs #2283 - less strict on the parameter match for Google Advanced search

- www.google.it/search?as_q=xxxxxx
- www.google.com.br/search?as_epq=xxxxxx
- www.google.de/search?as_q=xxxxxx
- www.google.fr/search?as_epq=xxxxxx
Stefan Giehl sgiehl added this to the Piwik 1.3 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.