Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update search engine detection for Yahoo! and Babylon #2304

Closed
robocoder opened this Issue · 4 comments

2 participants

@robocoder
Collaborator
  1. Allow wildcard matching on subdomains, e.g., '*.example.com' (but not as the primary URL).

  • May not allow more complex cases, e.g., *.example.{}, or *.example.com/path.

  1. Allow path matching where keyword parameter is unspecified, e.g., search.example.com/path/* (where * is the keyword)
@robocoder
Collaborator

From #2319 and the forum:

 us.yhs4.search.yahoo.com/yhs/search;_ylt=A0oG7qCW9ZhNdFQAuTQPxQt.?q=xxxxxxx
 us.nc.yhs.search.yahoo.com/if?p=keyword1+keyword2+keyword3&partnerid=yhs-if-timewarner&fr=yhs-if-timewarner&ei=UTF-8&YST_b=7&vm=p
 search.babylon.com/web/xxxxxx
@robocoder
Collaborator

(In [4696]) fixes #2304

@robocoder
Collaborator

This is the quick fix. Wildcard matching just isn't workable in the current algorithm. The "right" way may be to extract the "provider" (similar to the Provider plugin, or using the Public Suffix List).

@mattab
Owner

quick fix is good :)

@robocoder robocoder added this to the 1.5 - Piwik 1.5 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.