Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Updating pdf report with emailMe=0 throws SQLSTATE[HY000]: General error: 1366 Incorrect integer value: '' for column 'email_me' at row 1 #2360

Closed
JulienMoumne opened this Issue · 7 comments

3 participants

@JulienMoumne
Collaborator

On Windows 7x64, PHP 5.3.5, MySQL 5.5.9 x64, updating a pdf report with emailMe=0 fails and gives :

SQLSTATE[HY000]: General error: 1366 Incorrect integer value: '' for column 'email_me' at row 1

The problem seems to be located at plugins/PDFReports/API.php#L105.

In the API call, when

  • emailMe=false, (bool)$emailMe is equal to true (no SQL error is thrown)
  • emailMe=0, (bool)$emailMe is equal to false (a SQL error is thrown)
  • emailMe=true, (bool)$emailMe is equal to true (no SQL error is thrown)
  • emailMe=1, (bool)$emailMe is equal to true (no SQL error is thrown)

When using the PDFReport UI and unticking the email me checkbox, the request to the API is made with emailMe=0 and displays the SQL error. Same is true for plugins/PDFReports/tests/PDFReports.test.php#L131

@JulienMoumne
Collaborator
@robocoder

isn't the first case also a problem?

Does Snover's July '09 patch work? (We won't be upgrading to ZF2 because it requires php 5.3 features.)

@JulienMoumne
Collaborator

(In [4549]) refs #2360

@JulienMoumne
Collaborator

The patch for Zend Framework does work but not in all cases.

When an insert statement is cached core/Db/Adapter/Pdo/Mysql.php#L182, it does not go through core/Db/Adapter/Pdo/Mysql.php#L193, hence, doesn't go through libs/Zend/Db/Adapter/Pdo/Abstract.php#L228 where the patch is applied.

@mattab
Owner

(In [4551]) Refs #2360 does this fix it Julien? on my box it works before so I cant tell

@JulienMoumne
Collaborator

This patch works. Shouldn't this be done in a more generic way ?

Also, (int)'true' equals 0, but I guess it's ok.

@mattab
Owner

It should, but if the bug is in Zend there is not much we can do appart from submitting them the patch ;-)

@JulienMoumne JulienMoumne added this to the 1.4 - Piwik 1.4 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.