Skip to content

Loading…

PDF: Add page numbers #2401

Closed
mattab opened this Issue · 6 comments

3 participants

@mattab
Piwik Open Source Analytics member

It was suggested that we add Page numbers in the PDF reports, which are useful if users print out the report or discuss with their colleagues.

Not sure how hard it is to do this with the PDF lib but should be a quick fix?

@peterbo

I'd also include the report's date and (if available) period or something. I'll be fixing that in the next week.

@mattab
Piwik Open Source Analytics member

Adding in the footer the "Date Range: X" shown on the front page would be great indeed. Maybe also adding the website name?

@peterbo

(In [4675]) fixes #2401.

EDIT: Sorry for PDF.php - seems like i hit the source-code beautifier in this file.

Changes were made in rows 18, 61 and 99-107. The other files should be correctly showing the changes.

@robocoder

pi_tcpdf: if we're extending a lib, the new class file should be in the Piwik_ namespace.

@peterbo

(In [4676]) fixes #2401 with Anthon's comment incorporated. (use Piwik Namespace when extending a lib)

@mattab
Piwik Open Source Analytics member

(In [4677]) Refs #2401 Fixing build adding SVN keywords

@mattab mattab added this to the 1.5 - Piwik 1.5 milestone
@peterbo peterbo was assigned by mattab
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.