Empty Expires: headers causes proxy cache to not cache the request #2406

mattab opened this Issue May 5, 2011 · 4 comments

2 participants

Piwik Open Source Analytics member

Since I have my current internet connection I have been VERY frustrated by the fact, that on the demo, none of the assets are cached and always return 200. What happens, is that my internet provider proxy cache didn't honor the cache headers.

After researching the cause is that the Expires: header is empty.

Setting the Expires: header in the far future (as advised by Yahoo best practises) fixes the issue and causes the proxy cache they use to finally cache our assets.

Setting expires in the far future, means that the file will not even be requested at all, so that the browser will only request in the far future.

However it should work nicely for us, because we use a buster in the assets URLs so that when the assets change, the <.. src='...'> URL is also changed (good call on this one anthon ;)

Piwik Open Source Analytics member

Should be ok in most cases. The only exception is the js/ proxy serving piwik.js which has no cache buster string.

Piwik Open Source Analytics member

(In [4642]) Fixes #2406

Piwik Open Source Analytics member

In c1703a1: cache /js/ for 10 days rather than none. Refs #2406
From forum feedback: http://forum.piwik.org/read.php?2,112741

@mattab mattab added this to the 1.5 - Piwik 1.5 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab cache /js/ for 10 days rather than none. Refs #2406 c1703a1
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment