Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

simplify language and website selection #2415

Closed
sgiehl opened this Issue · 5 comments

2 participants

Stefan Giehl Matthieu Aubry
Stefan Giehl
Collaborator

the currently used fdd2div javascript is a bit crappy and the website selection quite too complicated

We should:

  • remove fdd2div and use native jquery (ui) functions instead
  • try to simplify the website selection (no different implemetations depeding on number of websites)
Stefan Giehl
Collaborator

(In [4660]) fixes #2415

  • removed fdd2div js
  • replaced fdd2div with jquery ui autocomplete in language selection
  • simplified site selector - now using same code for both variants
Stefan Giehl
Collaborator

(In [4661]) refs #2415 added missing doc block

Matthieu Aubry
Owner

good stuff!!
some feeedback

  • when there is one website only, the website selector should not have the arrow on the right and not be clickable
  • when search for "aiehgeaiuhg" and there is no website with such name, the line "There is no site for XXX" is clickable and leads to error, instead it should not be clickable

Note: to display search in site selector, you can set
[General]
autocomplete_min_sites = 2
in config file

Stefan Giehl
Collaborator

(In [4671]) refs #2415 fixed error occuring on clicking empty-result message

Stefan Giehl
Collaborator

(In [4672]) fixes #2415 handle case with only one site correct

Stefan Giehl sgiehl added this to the 1.5 - Piwik 1.5 milestone
Stefan Giehl sgiehl self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.