Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Charts - Top of chart cut off if data contains floats #2534

Closed
ziegenberg opened this Issue · 6 comments

2 participants

Daniel Ziegenberg Anthon Pang
Daniel Ziegenberg

In the Visitor Overview the Chart showing the actions per visit is cut off at the top.

I debugged through Chart.php and found the problem there. All the dates in Chart.php Line 133 are kind of floats with a comma as the decimal mark and the json_encode() three lines further creates rubbish as it takes the comma as a separator.

Daniel Ziegenberg

The comma as decimal mark is the same reason why the calculation in getMaxValue() does not work.

Anthon Pang
Collaborator

Yeah, I suspected this just after committing [4963]. I'll revert and find the root cause.

Anthon Pang
Collaborator

(In [4967]) fixes #2534 (I think)...output looked ok with de_DE.UTF-8

Anthon Pang
Collaborator

[4967] fixed a bug in the json_encode compatibility function for floats

Daniel Ziegenberg

Patched my system. Works!

@vipsoft: Thanks for fixing this bug! I really appreciate your short response time.

Anthon Pang
Collaborator

Thanks for confirming.

Daniel Ziegenberg ziegenberg added this to the 1.5.1 Piwik 1.5.1 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.