Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

.travel TLD not supported #2535

Closed
anonymous-piwik-user opened this Issue · 3 comments

4 participants

Anonymous Piwik user Fabian Becker Anthon Pang Matthieu Aubry
Anonymous Piwik user

Currently the TLD .travel is not supported under e-mail reports. When trying to add additional e-mail addresses for "Send report to:" Piwik gives the following error: "The email doesn't have a valid format. (person@domain.travel)"

Please could you add .travel to the TLD array.

Thanks

Fabian Becker
Collaborator

This is quite easy to fix, in core/Piwik.php:

return (preg_match('/^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9_.-]+\.[a-zA-Z]{2,4}$/', $email) > 0);

should actually be

return (preg_match('/^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9_.-]+\.[a-zA-Z]{2,6}$/', $email) > 0);

.museum/.travel and others are currently not accepted as valid TLDs by the regex above.

Anthon Pang
Collaborator

We also have internationalized tlds to address in #1755. Maybe address boyh tickeys at the same time, eg using ZF hostname validator.

Matthieu Aubry
Owner

(In [5239]) Fixes #2535

Anonymous Piwik user anonymous-piwik-user added this to the 1.6 Piwik 1.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.