Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Piwik reports 0 visits for single days ni some rare cases #2548

Closed
peterbo opened this Issue · 12 comments

4 participants

Peter Boehlke Matthieu Aubry Anthon Pang DaSch
Peter Boehlke
Collaborator

See http://forum.piwik.org/read.php?2,78544,78566, and http://forum.piwik.org/read.php?5,78506.

In my case, archiving is triggered by the browser. No cron job is running.

MySQL: 5.0.51a-24+lenny5
PHP: 5.2.6-1+lenny10

Peter Boehlke
Collaborator

Attachment:
piwik-bug.JPG

Matthieu Aubry
Owner

I have seen this bug occur maybe once every 6 months on demo.piwik.org as well. I suspect this comes from edge case when archiving is running twice at the same time, or maybe in the case of failing archiving, but I'm not sure.

Fixing the data is done by deleting the piwik_archive_xx table for the month containing the "zero data" reports, and then re-processing usually works fine.

Anthon Pang
Collaborator

See #2597 and #2574

Anthon Pang
Collaborator

(In [5052]) fixes #2602, fixes #2574, refs #2548, refs #2597

Anthon Pang
Collaborator

So, my thought on this is to use MySQL's advisory lock in launchArchiving()

        public function launchArchiving()
        {
                $this->get_lock();
                $this->initCompute();
                $this->compute();
                $this->postCompute();
                // we execute again the isArchived that does some initialization work
                $this->idArchive = $this->isArchived();
                $this->release_lock();
        }

Note: Lock names are system-wide. We could use something like:

$lockname = "piwik.$dbname.$tables_prefix.$idsite";
Anthon Pang
Collaborator

How long should the timeout be? And should it keep retrying indefinitely?

Matthieu Aubry
Owner

The lock is I think a good idea!

the lock should also contain the $date as we want to protect records for a given site on a given day to run concurrently.

The potential problem is for times that the archiving will crash (memory exhausted etc.) after the lock was acquired. Then, would we have to release it manually, or how would this work?

This has been a long standing bug this one, which would be nice to fix if it doesn't adds complexity etc. :)

Anthon Pang
Collaborator

By date, do you mean dateStart, dateEnd, and period?

If the mysql client connection is terminated, the lock is automatically released. There is a note somewhere which mentions a bug in older mysql versions: if the connection terminated, the lock wouldn't be released right away (i.e., it would still wait until the timeout expired).

I'm thinking a timeout of 30 seconds with no retry.

Anthon Pang
Collaborator

(In [5065]) fixes #2548, refs #2597 - use advisory locks

DaSch

Maybe this should be release in 1.5.2? They way till 1.6 is long and I don't want to manipulate my database to have the stats repaired

DaSch

how is this fixed now? will Piwik recognise the broken days? Will I still have to delete something in the database? Only fixing that this will not happen again is only the half-solution, repairing the result of this bug should be done for a real fix

Anthon Pang
Collaborator

It should be fixed for new data.

The Piwik update doesn't automatically repair previously archived data because it could potentially time-out (i.e., time intensive). It's also non-trivial to analyze previously archived data to see if an archived 0 really was a 0.

You're welcome to drop your piwik_archive_* tables, and run the archive script manually (or via cron).

Peter Boehlke peterbo added this to the 1.6 Piwik 1.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.