Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Google Mobile Image Search not recognized #2569

Closed
sgiehl opened this Issue · 4 comments

3 participants

@sgiehl
Collaborator

The mobile image search of google is not detected at all:

http://www.google.com/m/imgres?gl=fr&source=mog&client=ms-android-google&q=piwik&hl=fr&start=0&site=images&imgid=ANd9GcQxUscuUydTOpon0arCcnJsjK4HF4CHQe1xB72QGlnC4GOYD3duGPPHtqFU&imgsz=139568&imgurl=http://piwik.org/wp-content/uploads/2008/11/piwik-e280ba-web-analytics-reports7.png&imgrefurl=http://fr.piwik.org/&ht=367&wd=622&tbnh=80&tbnw=136&ei=bgUiTvikOtPo8QPlgruUAw&ved=0CAkQ9QEwAA

Problem seems to be the special handling for google image search in core/Common.php:

if($searchEngineName === 'Google Images'
    || ($searchEngineName === 'Google' && strpos($referrerUrl, '/imgres') !== false) )
{
    $query = urldecode(trim(self::getParameterFromQueryString($query, 'prev')));
    $query = str_replace('&', '&', strstr($query, '?'));
    $searchEngineName = 'Google Images';
}

/imageres is in the url, but there is no prev parameter...

@anonymous-piwik-user

Here is a patch I'm using to identify these searches as Google Images. Replace 1385-1391 block in Common.php (from trunk)

        if($searchEngineName === 'Google Images'
    || ($searchEngineName === 'Google' && strpos($referrerUrl, '/imgres') !== false) )
        {
            if(strpos($referrerUrl, '&prev=') !== false)
            {
                $query = urldecode(trim(self::getParameterFromQueryString($query, 'prev')));
                $query = str_replace('&', '&', strstr($query, '?'));
            }
        $searchEngineName = 'Google Images';
    }
@anonymous-piwik-user

Attachment: Associated Patch
gi.diff

@anonymous-piwik-user

The unit test patch for this is on the forum:
http://forum.piwik.org/read.php?2,80107

@robocoder
Collaborator

(In [5143]) fixes #2569, fixes #2616, refs #2652, adds Google Video

@sgiehl sgiehl added this to the 1.6 Piwik 1.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.