Piwik_Url: getCurrentSchema() should check assume_secure_protocol #2606

Closed
robocoder opened this Issue Aug 2, 2011 · 5 comments

2 participants

@robocoder

#2594 was nagging at me all night.

I did a review of the code base, and there doesn't appear to be a reason why getCurrentSchema() couldn't return https when assume_secure_protocol = 1.

This would eliminate the special cases in the code. So, let's refactor and clean this up.

@robocoder

(In [5070]) fixes #2606, refs #2594

@mattab
Piwik Open Source Analytics member

thanks for all the technical debt fixes.

Regarding this change,

  • can you please confirm that you tested to load https://server/piwik and all files were loading fine over https without triggering browser warning?
  • how much effort (hours) would it take to have a webtest testing to load the https version of piwik and verify that all links / ressources are https ?

thx

@mattab
Piwik Open Source Analytics member

reopening pending some QA questions above, vipsoft would you mind taking a quick look?

@robocoder

There's no warning if you have a valid certificate (or accepted a self-signed one).

Webtest: The main stumbling blocks are going to be the jetty/jenkins environment, and how to reliably test ajax requests and dynamic content. (The latter already causes sporadic test failures.)

@mattab
Piwik Open Source Analytics member

thanks for confirming

@robocoder robocoder added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
@czolnowski czolnowski pushed a commit to czolnowski/piwik that referenced this issue Sep 19, 2014
Michał Gaździk working add/remove/edit of user groups, task #2606 19b6a26
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment