Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP


Piwik_Url: getCurrentSchema() should check assume_secure_protocol #2606

robocoder opened this Issue · 5 comments

2 participants

Anthon Pang Matthieu Aubry
Anthon Pang

#2594 was nagging at me all night.

I did a review of the code base, and there doesn't appear to be a reason why getCurrentSchema() couldn't return https when assume_secure_protocol = 1.

This would eliminate the special cases in the code. So, let's refactor and clean this up.

Anthon Pang

(In [5070]) fixes #2606, refs #2594

Matthieu Aubry

thanks for all the technical debt fixes.

Regarding this change,

  • can you please confirm that you tested to load https://server/piwik and all files were loading fine over https without triggering browser warning?
  • how much effort (hours) would it take to have a webtest testing to load the https version of piwik and verify that all links / ressources are https ?


Matthieu Aubry

reopening pending some QA questions above, vipsoft would you mind taking a quick look?

Anthon Pang

There's no warning if you have a valid certificate (or accepted a self-signed one).

Webtest: The main stumbling blocks are going to be the jetty/jenkins environment, and how to reliably test ajax requests and dynamic content. (The latter already causes sporadic test failures.)

Matthieu Aubry

thanks for confirming

Anthon Pang robocoder added this to the 1.6 Piwik 1.6 milestone
Anthon Pang robocoder self-assigned this
Marcin Czołnowski czolnowski referenced this issue from a commit in czolnowski/piwik
Michał Gaździk mgazdzik working add/remove/edit of user groups, task #2606 19b6a26
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.