Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Unit test ipv6 failing on windows #2622

Closed
mattab opened this Issue · 12 comments

4 participants

@mattab
Owner

I have the following unit test failure on local windows box,

Fail: D:\piwik\svn\trunk/tests/core/IP.test.php -> Test_Piwik_IP -> test_getHostByAddr -> ::1 -> ip6-localhost at line 582

Infos:
Apache/2.2.17 (Win32) mod_ssl/2.2.17 OpenSSL/0.9.8o PHP/5.3.2 mod_perl/2.0.4 Perl/v5.10.1
PHP Version 5.3.6

Any idea?

@robocoder

What do you get for:

<?= php_uname('n');
@mattab
Owner

I get: string 'MYLAPTOP' (length=8)

@robocoder

(In [5093]) refs #2622

@mattab
Owner

After svn up, still failing with:

Fail: Test_Piwik_IP -> test_getHostByAddr -> ::1 -> ip6-localhost at line 582

@robocoder

What do you get for Piwik_IP::getHostByAddr('::1') ?

Alternately, we could simply disable this test on Windows.

@mattab
Owner

I get an empty string for Piwik_IP::getHostByAddr('::1')

Is it OK to disable the test you think?

@robocoder

(In [5119]) fixes #2622

@robocoder

(In [5120]) refs #2622 - strtolower converts it to an empty string

@mattab
Owner

Sorry it is still failing on my config:
Fail: Test_Piwik_IP -> test_getHostByAddr -> ::1 -> ip6-localhost at line 582

@robocoder

(In [5126]) fixes #2622

@anonymous-piwik-user

In 97de0ab: Build was failing again. Result of getHostByAddr
depends on /etc/hosts. On most systems ::1 will resolve
to ipv6-localhost, but for Travis it resolves to localhost.

refs #2622

@halfdan
Collaborator

The following lines are desirable for IPv6 capable hosts

::1 localhost ip6-localhost ip6-loopback

@mattab mattab added this to the 1.6 Piwik 1.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.