Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

trunk: Hexadecimal encoded URLs don't decoded #2631

Closed
anonymous-piwik-user opened this Issue · 8 comments

3 participants

Anonymous Piwik user Anthon Pang Matthieu Aubry
Anonymous Piwik user

Links in a website of the form <a href="mailto:%69%6e%66%6f@%65%78%61%6d%70%6c%65.%63%6f%6d">info@example.com</a> don't get decoded. In the user-log they are shown still encoded.
They should get decoded (normalized) befor they are saved into the database.

Anonymous Piwik user

Attachment: Example of the user-log with an undecoded URL
Not_urldecoded_URL.png

Anthon Pang
Collaborator

(In [5121]) fixes #2631

Anthon Pang
Collaborator

(In [5122]) fixes #2631

Matthieu Aubry
Owner

The changeset decodes the referer, but the bug report mentions the "link" parameter. Testing with proposed example I still see in the GET request: link=mailto:%69%6e%66%6f@%65%78%61%6d%70%6c%65.%63%6f%6d

Anthon Pang
Collaborator

(In [5142]) fixes #2631

Matthieu Aubry
Owner

(In [Revert 5121) causing buggy referrer keywords when accents/umlauts etc. as per report in http://forum.piwik.org/read.php?2,81827 Refs #2631

Matthieu Aubry
Owner

I think this bug is still fixed since I only removed the unescape() of the referrer, this bug is about the click tracking?

Anthon Pang
Collaborator

ah; ok

Anonymous Piwik user anonymous-piwik-user added this to the 1.6 Piwik 1.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.