Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Actions.getPageTitle and getPageUrl should work like other API methods with date=last30 #2662

Closed
mattab opened this Issue · 4 comments

2 participants

@mattab
Owner

Currently it returns an error: http://demo.piwik.org/?module=API&method=Actions.getPageTitle&idSite=7&period=day&date=last30&format=html&token_auth=anonymous&pageName=Piwik%20Forums

We should patch the code so that the datatable accept to work with date=last30

@BeezyT
Collaborator

(In [5172]) Refs #2662 Actions.get* for date range

@mattab
Owner

Code review:

  • excellent work!
  • test: all the last30 for getPageUrl etc. only had 0 visit days. Would you be able to add a test that shows results with data for the queried dates?
@mattab
Owner

Note: for the tests, it will be pretty easy to add them, see example in this commit: http://dev.piwik.org/trac/changeset/5197#file2

@mattab
Owner

(In [5235]) Fixes #2667

  • Stop aggregating visits for Custom variables of scope "page"
    • still OK for scope "visit" since there is supposed to be one custom var value per custom variable name for a given visit
  • Now we always display the Actions columns so that these rows with no visit still show the number of Actions
  • cleaned up from custom var output report, removed some "price_viewed" column left out

UI Change (future FAQ maybe...)

  • When there is a "Visits" column for the Custom Variable report with a value of "-" (hyphen) then it means this custom variable was used with scope=page.

Fixes #2662

  • Added integration tests testing getPageUrl with multiple periods and websites
  • fixed a bug when idSite=all or 1,2,3
@mattab mattab added this to the 1.6 Piwik 1.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.