Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Allow JSONP parameter name to be either "callback" or " jsoncallback" #2679

Closed
anonymous-piwik-user opened this Issue · 5 comments

3 participants

Anonymous Piwik user Anthon Pang Matthieu Aubry
Anonymous Piwik user

Why do we require "jsoncallback=?" and not just the "callback=?" that jQuery defaults to? It would be a lot easier on new developers if their jQuery calls just worked instead of having to append an extra hash.

Anthon Pang
Collaborator

JSONP doesn't dictate the parameter name. But I suspect when jsonp support was added, the parameter name didn't default to "callback". (Today, this appears to de facto with jquery, dojo, and extjs.)

I'm guessing we would have to make this configureable since it is a potential compat buster.

Anthon Pang
Collaborator

(In [5216]) fixes #2679 - use de facto standard "callback" for the JSONP callback parameter name

Matthieu Aubry
Owner

changeset not BC, we should read both jsoncallback and callback parameter for BC

Anthon Pang
Collaborator

(In [5221]) fixes #2679 - fallback to jsoncallback (BC)

Anthon Pang
Collaborator

(In [5222]) refs #2679

Anonymous Piwik user anonymous-piwik-user added this to the 1.6 Piwik 1.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.