Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Handle missing config file setting with a clean error message #2684

Closed
anonymous-piwik-user opened this Issue · 4 comments

2 participants

@anonymous-piwik-user

when the branding section is missing from config.ini.php, piwik generates mutliple screens full of errors/backtraces (due to objects in the config object not existing), this should be handled more gracefully, or at least generate a meaningful error message.
happened to me after an upgrade from 1.4 to 1.5.1. (not necessarily the upgrade processes' fault tho')
Keywords: branding logo

@mattab
Owner

I tried replicate the issue (remove branding from global.ini.php or from config.ini.php) but I couldnt see error messages. Can you please explain how to reproduce the bug?

@mattab
Owner

I could reproduce the bug. thanks for the report!

@mattab
Owner

(In [5253]) Fixes #2684 Now displaying clean error message with probably explanation and suggestion on how to fix the problem (ie. reupload global.ini.php )

@anonymous-piwik-user

good work, thanks!
(i'd agree this is a somewhat obscure situation, but i see not much code is needed to handle it better)

btw, i as far as i can tell the root cause was that i tried to replace the config directory with a symlink to one outside the piwik directory (to make (manual) upgrading smoother), which got replaced with a blank new directory during the upgrade(?), and then put the link (to the non-upgraded copy) back.
i guess it'd be better to only link config.ini.php then...

@anonymous-piwik-user anonymous-piwik-user added this to the 1.6 Piwik 1.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.