Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

UserAgentParser: should report Android's browser as Safari #2694

Closed
anonymous-piwik-user opened this Issue · 7 comments

3 participants

Anonymous Piwik user Anthon Pang Matthieu Aubry
Anonymous Piwik user

XXX.XXX.XXX.XXX - - +0200 "GET /dummypage.html HTTP/1.1" 200 2843 "http://www.example.org/" "Mozilla/5.0 (Linux; U; Android 2.2; de-de; HTC Desire 2.33.161.2 Build/FRF91) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Mobile Safari/533.1"

will be detected as "Android 4.0 with plugins flash enabled"

Anthon Pang
Collaborator

If you're looking at the Browser report, it's reporting the browser version. Version/4 is explicitly set in the user agent so it is customary to use that value. Using the Android OS version is wrong imho. Maybe we should just report it as Safari or Mobile Safari?

Anthon Pang
Collaborator

A patch for Chrome on Android reportedly landed this past week, so we'll report as Safari to avoid later confusion.

Anthon Pang
Collaborator

(In [5272]) fixes #2694 - detect current Android browser as Safari (like iPad/iPhone/iPod); added a ficticious mobile Chrome user agent (commented out for now, but it works)

Anthon Pang
Collaborator

(In [5273]) refs #2694 - remove remnants of "Android" browser (obsolete)

Anthon Pang
Collaborator

FYI if/when mobile Chrome comes to Android, it'll be reported as Chrome

Anonymous Piwik user

This bug is not fixed, the problem still persists in version 1.12.

Matthieu Aubry
Owner

What is the bug exactly? what user agent, what is behavior VS what do you expect? create a new ticket

Anonymous Piwik user anonymous-piwik-user added this to the 1.6 Piwik 1.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.