Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add support for segmentation on Goals.getItems* API #2781

Closed
mattab opened this Issue · 5 comments

2 participants

Matthieu Aubry Anthon Pang
Matthieu Aubry
Owner

It might be the last API that does not implement $segment support. It should!

  • add $segment support parameter to all Goals API that do not yet support it.

Reported in forum post.

Anthon Pang
Collaborator

dyslexia

Matthieu Aubry
Owner

Pull request: #121

Matthieu Aubry
Owner

In 7778531: Merge pull request #121 from piwikpro-team/2781-segmentation-on-Goals.getItems

Fixes #2781 Add support for segmentation on Goals.getItems* API. Kuddos for the nice pull request and tests!

Matthieu Aubry
Owner

In 44d9bce: Refs #2781 PR #121 Modifying tests fixtures to generate visits from two countries so that it's clear that the Segmenting on the country selects only that country.

Matthieu Aubry
Owner

In 93d5d1f: Refs #2781 PR #121 Fixing regression the "distinct idvisit" was removed in the PR

Matthieu Aubry mattab self-assigned this
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Marcin Czołnowski czolnowski #2781
Improvements in queryEcommerceItems function which make it works with segments query builder
32f5135
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #2781 PR #121 Modifying tests fixtures to generate visits from t…
…wo countries so that it's clear that the Segmenting on the country selects only that country.
44d9bce
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Matthieu Aubry mattab Refs #2781 PR #121 Fixing regression the "distinct idvisit" was remov…
…ed in the PR
93d5d1f
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.