Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Regression: duplicated visits are created when IP is different every page view #2785

Closed
mattab opened this Issue · 3 comments

1 participant

@mattab
Owner

This is definitely a regression introduced some time in the last few months.

When the visitor IP is changing, AND the visitor supports the id cookie, we should properly detect the unique visitor. Instead it seems that in some cases there is a new visit created on every page view. See attached screenshot.

@mattab
Owner

Attachment:
multiple visits.png

@mattab
Owner

(In [5530]) Refs #2785 - Changing test to highlight the problem, the build should fail

@mattab
Owner

(In [5531]) Fixes #2785

  • Finally getting the code right after 4 years...! the SELECT will now select several rows and order by priority based on the matched attribute, but not on intranet, and only when there was a visitor id found in the 1st party/3rd cookie, or via setForcedVisitorId()
  • Fixes notices when invalid ID supplied/ When provider plugin disabled
@mattab mattab added this to the 1.7 Piwik 1.7 milestone
@mattab mattab self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.