Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

PHP 5.4.0RC3 compatibility #2806

Closed
robocoder opened this Issue · 17 comments

1 participant

@robocoder
Collaborator

Tested with PHP 5.4.0 RC3

@robocoder
Collaborator

(In [5493]) refs #2806

@robocoder
Collaborator

(In [5494]) refs #2806

@robocoder
Collaborator

Notices to fix:

Strict Standards: Declaration of MockPiwik_Access::checkUserHasAdminAccess() should be compatible with Piwik_Access::checkUserHasAdminAccess($idSites)
Strict Standards: Declaration of MockPiwik_Access::checkUserHasViewAccess() should be compatible with Piwik_Access::checkUserHasViewAccess($idSites)
Strict Standards: Declaration of MockPiwik_Access::reloadAccess() should be compatible with Piwik_Access::reloadAccess(Piwik_Auth $auth = NULL)
Strict Standards: Declaration of MockPiwik_Access::setSuperUser() should be compatible with Piwik_Access::setSuperUser($bool = true)
Strict Standards: Declaration of Piwik_DataTable_Renderer_Csv::renderHeader() should be compatible with Piwik_DataTable_Renderer::renderHeader()
Strict Standards: Declaration of Piwik_Period_Year::toString() should be compatible with Piwik_Period::toString($format = 'Y-m-d')
Strict Standards: Non-static method Mock::generate() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method Mock::generatePartial() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleErrorQueue::getSeverityAsString() should not be called statically
Strict Standards: Non-static method SimpleReporter::inCli() should not be called statically
Strict Standards: Non-static method SimpleTest::getContext() should not be called statically
Strict Standards: Non-static method SimpleTest::getContext() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTest::getMockBaseClass() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTest::ignore() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTest::ignoreParentsIfIgnored() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTest::isIgnored() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTestCompatibility::isA() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method TestSuite::getBaseTestCase() should not be called statically, assuming $this from incompatible context
@robocoder
Collaborator

(In [5506]) refs #2806 - refactor fix for Declaration of Piwik_Period_Year::toString() should be compatible with Piwik_Period::toString($format = 'Y-m-d')

@robocoder
Collaborator

(In [5507]) refs #2806 - minimal changes to simpletest to accommodate php 5.4.0rc2 incompatibilities

@robocoder
Collaborator

(In [5508]) fixes #2806, refs #2809 - quick fix

@robocoder
Collaborator

Sorry that was just the first batch -- there are additional notices to be addressed. =P

@robocoder
Collaborator

(In [5511]) refs #2806 - not sure why but r5506 introduced a regression; reverting and adding a dummy parameter to satisfy php 5.4

@robocoder
Collaborator

(In [5512]) refs #2806 - silent array to string conversion now emits notice

11 Nov 2011, PHP 5.4.0 RC1
- General improvements:
  . Changed silent conversion of array to string to produce a notice. (Patrick)
@robocoder
Collaborator

(In [5518]) refs #2806

@robocoder
Collaborator

Sorry, I had a dyslexic morning and ref'd the wrong ticket in my commits.

(In [5513]) refs #2806 - Non-static method Piwik_Tracker_Db::isProfilingEnabled() should not be called statically

(In [refs #2806 - Unexpected PHP error Array to string conversion) severity

(In [refs #2806 - Unexpected PHP error Array to string conversion) and Only variables should be passed by reference

(In [5516]) refs #2806

(In [refs #2806 - revert regression in 5515)

@robocoder
Collaborator

(In [5524]) refs #2806

@robocoder
Collaborator

(In [5525]) refs #2806

@robocoder
Collaborator

(In [5526]) refs #2806 - fix message

@robocoder
Collaborator

(In [5527]) fixes #2806 - finally, remove this webtest (Piwik 1.0 is not 5.4.0 compatible); we still test the install/update from 1.1.1 (which is about a year old now)

@robocoder
Collaborator

(In [5538]) refs #2806 - these were caught by php -l

@robocoder
Collaborator

(In [5539]) refs #2806 - make it clearer that this parameter is ignored

@robocoder robocoder added this to the 1.7 Piwik 1.7 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.