Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

javascript error on Goals page in IE 7 due to unexpected comma #2845

Closed
anonymous-piwik-user opened this Issue · 2 comments

2 participants

@anonymous-piwik-user

When one goes to the Goals page in IE 7 they get the "Error on Page" indicator in the status bar at the bottom and none of the links for viewing by type work. For example, if you want to view goals by custom varaibles the link doesn't work.

I looked at the page in FireFox and it works there so this seems to be an issue that is specific to IE. Running Piwik version 1.6.

I finally managed to track down the error by running the various javascript code pieces through jslint.

Inside of table_by_dimension.tpl (in \piwik\plugins\Goals\templates) there is a javascript block that contains the following:

var widgetParameters = {
'module': module,
'action': action,
};

Take the hanging comma off the end of that (right after action) and now all is happy.

@robocoder
Collaborator

(In [5643]) fixes #2845

@robocoder
Collaborator

Thanks!

@anonymous-piwik-user anonymous-piwik-user added this to the 1.7 Piwik 1.7 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.