Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Back button does not work when using Chrome browser #2922

Closed
mattab opened this Issue · 9 comments

2 participants

Matthieu Aubry Stefan Giehl
Matthieu Aubry
Owner

Regressions

  • Back button does not work anymore in Chrome. The #fragment displays the previous fragment but the menu is not loaded
  • When clicking on the link "Websites" below the graph in the Referrers > Overview page, the "website" report loads OK, but it is not colored orange in the menu
Stefan Giehl
Collaborator

First point maybe caused by a jQuery update? I will have a look at that.
Second point may be caused by different urls. clicking the menu the link has action=indexWebsites. clicking that website link it is action=getWebsites

Stefan Giehl
Collaborator

(In [5829]) refs #2922 fixes problems with not highlighted menu entries

Stefan Giehl
Collaborator

hm... had that history back for chrome ever worked? Just tested it in piwik 1.6 and even in an 1.0, but it didn't work in both. Maybe we need to switch the history plugin to get it fixed.

Stefan Giehl
Collaborator

(In [5832]) fixes #2922 replaced jquery.history plugin with an newer version. tested history function in IE 7-9, Chrome, Safari (Win), Opera, Firefox - works so far :)
@matt would you please test that, too. Didn't have much time for that right now.

Matthieu Aubry
Owner

Steve that's great!! thanks for the quick fixes. Even better that it didn't use to work and now it does ;)

Matthieu Aubry
Owner

There is one regression: clicking on the same menu again does not reload the content. Clicking on the same menu should reload the content.

Stefan Giehl
Collaborator

(In [5853]) fixes #2922 needed to patch the new history plugin as the reload was prevented there. Only tested that changes in newer browsers which supports the hashchange event (see http://help.dottoro.com/ljgggdjt.php for supported browsers)

Stefan Giehl
Collaborator

btw. current implementation does not save the reload in history. that meens hitting the back button after the reload switches back to the hash that was loaded before the hash that was reloaded.

Matthieu Aubry
Owner

I thought you were sleeping so I was trying to fix the problem myself but I already spent 40 minutes on it and couldn't find the fix!! THANKS!

Matthieu Aubry mattab added this to the 1.7 Piwik 1.7 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.