Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Opt-Out does not fallback to English #2960

Closed
anonymous-piwik-user opened this Issue · 5 comments

3 participants

@anonymous-piwik-user

If I'm calling the URL [http://example.com/piwik/index.php?module=CoreAdminHome&action=optOut&language=tw] a page with Language file 'tw' not found. is shown and some links to piwik are shown. This breaks usability and the integrated user interface. As I'm integrating with Drupal, I have no clue what languages Piwik supports. Drupal supports any language.

I do not like to add any static conditions to the Piwik module code just to make this working at all times and fallback to English if Piwik have no support for a language.

Please make a fallback to English if the language is not found in Piwik.

@mattab
Owner

You can call the API http://demo.piwik.org/index.php?module=API&method=LanguagesManager.getAvailableLanguages to get the list of supported languages.

@mattab
Owner

I agree that because "opt-out" is public on the website, it would make sense in this case to catch the exception and use english instead.

@robocoder
Collaborator

(In [5871]) refs #2960

@robocoder
Collaborator

Instead of the hardcoded "en", the "fallback language" is default_language in config/global.ini.php.

I'll add some unit tests later.

@mattab
Owner

Tests would be nice to have for sure :)

otherwise looks good to me!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.