Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Refactor Upgrader to ensure the new code is reloaded after overwriting old files #3021

Closed
robocoder opened this Issue · 16 comments

2 participants

Anthon Pang Matthieu Aubry
Anthon Pang
Collaborator

I hate #1331 workarounds. It's uglifying the #1713 improvements.

We need to make a cleaner break. We need to force a new browser request so that we aren't loading new classes while instances of old classes are in memory.

Anthon Pang
Collaborator

(In [5988]) refs #1331, refs #3021 - remove #1331 hacks

Anthon Pang
Collaborator

(In [5991]) fixes #3021, refs #1331 - adds Piwik_View_OneClickDone

During a Piwik software update, there will be instances of old classes
loaded in memory. This is problematic as we will start to instantiate
new classes which may not be backward compatible. This class provides
a clean bridge/transition by forcing a new request.

This class needs to be self-contained, with no external dependencies.

Matthieu Aubry
Owner

Every time I updated wordpress I noticed they were doing this and thought "we should do it too" :)

Great idea, well done!! This will save a lot of pain in the future.

Matthieu Aubry
Owner

(in the right ticket this time)
Review/questions:

  • Did you test auto-updating from 1.7.1 to trunk?
  • Did you test auto-updating from trunk to an imaginative next release?
  • Did you check that errors/warning are reported when there are some?

Thanks!

Anthon Pang
Collaborator

I tested 1.0 to trunk.

I instrumented the errors for testing. (Limited time)

We'll be able to test the other scenarios when I get Selenium running on dev6. (I have it working locally.) I've also done some work with Behat/Mink but will defer that until the switch to phpunit.

Matthieu Aubry
Owner

Selenium running on dev6. (I have it working locally.)
Excellent news!!

I've also done some work with Behat/Mink but will defer that until the switch to phpunit.
Sounds fun too!

I have looked quickly and it looks interesting. Do you plan to integrate this to improve our current test coverage, or at first to update existing webtests and make it easier to write new web tests?

Tests
Testing the case "Update from trunk to fake next release" is important too (as I assume it triggers different code path)

Matthieu Aubry
Owner

Reopening until confirmation that trunk -> fake 1.8 update works

Anthon Pang
Collaborator

(In [6008]) refs #3021 - form tweaks

Anthon Pang
Collaborator

(In [6009]) refs #3021 - fix button

Anthon Pang
Collaborator

Behat/Mink testing won't improve test coverage. Its main benefit is enabling a more natural language for writing acceptance tests.

We've unfortunately lost a lot of web test coverage due to WebTest + jQuery/jQuery-UI incompatibilities. Replacing WebTest with Selenium will be my priority after #3030.

Matthieu Aubry
Owner

Todo before closing this ticket:

  • test "Update from trunk to fake next release" is important too (as I assume it triggers different code path)

@vipsoft Is there any other pending task? thx

Matthieu Aubry
Owner

For testing auto update easily, see #3071

Matthieu Aubry
Owner

I tested an automatic upgrade from 1.7.1 to 1.8-rc2 but after 1min20, after it unpacked, etc. it redirected to login screen with errors "Login / password not provided"... there was no summary of the auto update. Maybe auto upgrade is partially broken (the UI feedback part) but files seemt o have downloaded and overwrite OK.

Matthieu Aubry
Owner

(In [6404]) Fixes #3071 New config setting to Allow automatic upgrades to Beta or RC releases
[Debug]
allow_upgrades_to_beta = 0

practical to test for Auto upgrades or for users & devs Refs #3021

Matthieu Aubry
Owner

Great work on this one Anthon, clean & few code for an elegant solution to a recurrent issue. Now we don't need the ugly is_class() calls? :)

Matthieu Aubry
Owner

I did a test upgrading from rc4 to rc5 and it worked fine. not sure what hapened in my test before.

It will feel safer with the webtest from 1.0 upgrade ;)

Anthon Pang robocoder added this to the Piwik 1.8 milestone
Anthon Pang robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.