Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Allow to customize the maximum URL split which defaults to 10 URL directories max #3102

Closed
mattab opened this Issue · 4 comments

2 participants

@mattab
Owner

The harcoded "10" should be customizable via config file setting.

See in plugins/Actions/Actions.php

$limitLevelSubCategory = 10

@diosmosis
Collaborator

(In [6278]) Fixes #3102, added config setting 'action_category_level_limit' as replacement for Piwik_Actions::$limitLevelSubCategory constant.

@mattab
Owner

Thanks for the change. It allows up to level 15, but in this case we would liket o really allow for more which some users will want to do for sure ;)

So I propose to add a setter on DataTable to increase the MAXIMUM_DEPTH_LEVEL_ALLOWED which should be changed to a private member.

This way it would work in all cases. We don't need to enforce an absolute max, users will be careful changing these values and know what risks they take (php memory exhausted error mainly)

@diosmosis
Collaborator

(In [6294]) Fixes #3102, removed upper limit for 'action_category_level_limit' config setting by making MAXIMUM_DEPTH_LEVEL_ALLOWED settable.

@mattab
Owner

(In [6307]) Refs #3102 removing unused function

@mattab mattab added this to the Piwik 1.8 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.