Skip to content


UI: small code improvements to selector to choose number of rows #3150

mattab opened this Issue · 1 comment

2 participants

Piwik Open Source Analytics member

Reported by Timo in the original ticket #2461

  • The body mouseup event registered in datatable.js for the feature is never unbound. Shouldn't it be only bound after opening the dialog and unbound after closing it?
  • Binding the event to the body is problematic in Chrome. The body does not strech over the entire window but only as far as there is content. If you click the lower area of the window, the boxes don't close. You could use document instead of body.
  • The box can be opened on two tables if there are two on the page. This is connected to the overall event handling I already commented on.
Piwik Open Source Analytics member

(In [6308]) fixes #3150 fixed problems with events

@mattab mattab added this to the 1.12.x - Piwik 1.12.x milestone
@sgiehl sgiehl was assigned by mattab
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.