Skip to content

Loading…

mobile vs. desktop pie chart does not show all values #3192

Closed
mattab opened this Issue · 19 comments

2 participants

@mattab
Piwik Open Source Analytics member

Reported in forum

Also it seems the pie graphs use filter_limit instead of filter_truncate?

@diosmosis
Piwik Open Source Analytics member

(In [6516]) Fixes #3192, fixed bug in UserSettings where GroupBy filter was queued instead of applied directly & fixed regression where generic filters were run when displaying pie graphs.

NOTES:

  • Refactored ViewDataTale.php a bit to clear up code.
@mattab
Piwik Open Source Analytics member

The disableGenericFilters() seems dangerous here - because the graph must sometimes apply generic filter data (eg. I haven't tested but filtering with filter_pattern or using filter_truncate should still work) ?

Were the generic filters causing a problem in the case of pie graphs ?

@diosmosis
Piwik Open Source Analytics member

Replying to matt:

The disableGenericFilters() seems dangerous here - because the graph must sometimes apply generic filter data (eg. I haven't tested but filtering with filter_pattern or using filter_truncate should still work) ?

Were the generic filters causing a problem in the case of pie graphs ?

The limit filter was reducing the number of values before. Also, this bug was introduced (I think) w/ #3004 (or maybe the 'report was generated on' issue) when I put the postDataTableLoaded call in there, so the generic filters were never called before. (Which might be another bug, I guess :)).

We could enable generic filters and move the call to after the AddSummaryRow filter is used.

@mattab
Piwik Open Source Analytics member

Replying to capedfuzz:

Replying to matt:

The disableGenericFilters() seems dangerous here - because the graph must sometimes apply generic filter data (eg. I haven't tested but filtering with filter_pattern or using filter_truncate should still work) ?

Were the generic filters causing a problem in the case of pie graphs ?

The limit filter was reducing the number of values before. Also, this bug was introduced (I think) w/ #3004 (or maybe the 'report was generated on' issue) when I put the postDataTableLoaded call in there, so the generic filters were never called before. (Which might be another bug, I guess :)).

Umh OK but can you take this call out then? ;-)

We could enable generic filters and move the call to after the AddSummaryRow filter is used.

Sounds good, as long as they run before the queued filters

@diosmosis
Piwik Open Source Analytics member

Replying to matt:

Replying to capedfuzz:

Replying to matt:

The disableGenericFilters() seems dangerous here - because the graph must sometimes apply generic filter data (eg. I haven't tested but filtering with filter_pattern or using filter_truncate should still work) ?

Were the generic filters causing a problem in the case of pie graphs ?

The limit filter was reducing the number of values before. Also, this bug was introduced (I think) w/ #3004 (or maybe the 'report was generated on' issue) when I put the postDataTableLoaded call in there, so the generic filters were never called before. (Which might be another bug, I guess :)).

Umh OK but can you take this call out then? ;-)

I think the call was needed for #3004, so priority filters will be run on a view.

We could enable generic filters and move the call to after the AddSummaryRow filter is used.

Sounds good, as long as they run before the queued filters

Just tried this and it won't work. datatable.js will send the filter_limit parameter when switching to the pie graph view. I'll investigate alternative solutions.

@diosmosis
Piwik Open Source Analytics member

(In [6558]) Fixes #3192, allow limit filter to be skipped by ViewDataTable descendents & skip in GenerateGraphData.

@mattab
Piwik Open Source Analytics member

Maybe this problem could be fixed in the Javascript rather than changing the Api of postDataTableLoadedFromAPI() - changing Core API is always risky and more hacky.

For example maybe the commit [6558] could be reverted the following

Index: plugins/CoreHome/templates/datatable.js
===================================================================
--- plugins/CoreHome/templates/datatable.js (revision 6564)
+++ plugins/CoreHome/templates/datatable.js (working copy)
@@ -542,6 +542,10 @@
                var filters = self.resetAllFilters();
                self.param.flat = filters.flat;
                self.param.columns = filters.columns;
+
+               // when switching to display graphs, reset limit
+               delete self.param.filter_offset;
+               delete self.param.filter_limit;

                self.param.viewDataTable = viewDataTable;
                self.reloadAjaxDataTable();

@diosmosis
Piwik Open Source Analytics member

Replying to matt:

Maybe this problem could be fixed in the Javascript rather than changing the Api of postDataTableLoadedFromAPI() - changing Core API is always risky and more hacky.

For example maybe the commit [6558] could be reverted the following

Index: plugins/CoreHome/templates/datatable.js
===================================================================
--- plugins/CoreHome/templates/datatable.js   (revision 6564)
+++ plugins/CoreHome/templates/datatable.js   (working copy)
@@ -542,6 +542,10 @@
              var filters = self.resetAllFilters();
              self.param.flat = filters.flat;
              self.param.columns = filters.columns;
+
+             // when switching to display graphs, reset limit
+             delete self.param.filter_offset;
+             delete self.param.filter_limit;

              self.param.viewDataTable = viewDataTable;
              self.reloadAjaxDataTable();

I thought of that, but it won't work. If you remove the params when loading a graph, the table won't have the limit/offset when you switch back. Which is also why I didn't add a disableLimit method (like the disableSort method).

@mattab
Piwik Open Source Analytics member

I think it's OK if the tables don't have the limit information after looking at the graph... Limit can be lost when switching contest, we want to keep: Searched string, Flattened, etc. but not limit.

@diosmosis
Piwik Open Source Analytics member

I guess if you're ok w/ that info being lost, the change you proposed will work, but I don't see the problem w/ disabling the limit filter for graphs. Graphs will always provide an overview of all the information not a subsection of it, so limit/offset will never have any meaning for them. Deleting the parameters in the JS to avoid a bug in the php seems more hacky than allowing descendants of ViewDataTable to customize behavior.

@diosmosis
Piwik Open Source Analytics member

(In [Refs #3192, revert 6558), modify datatable JS so limit/offset parameters are not sent to graphs.

@mattab
Piwik Open Source Analytics member

Looks good - can I please make one more request,

  • I think it would be nice to always show "Mobile" in the datatable row even if 0 visits, to make the report consistent with the title "Desktop VS Mobile" ?
@diosmosis
Piwik Open Source Analytics member

Attachment: Patch for always showing mobile/desktop rows.
3192.diff.tar.gz

@diosmosis
Piwik Open Source Analytics member

I had to add a new filter for the last request (since API methods can get DataTable_Arrays). Take a look and let me know if it's good to commit.

@mattab
Piwik Open Source Analytics member

Look good - however you can just inline the filter in this case, since it's as simple as creating the filter, and minimizing number of small filters is better.

@diosmosis
Piwik Open Source Analytics member

(In [6617]) Fixes #3192, modified getMobileVsDesktop report to always show Mobile/Desktop rows, even if there're visits of one type.

@mattab
Piwik Open Source Analytics member

(In [6623]) Refs #3192 refactoring

@mattab
Piwik Open Source Analytics member

(In [6625]) Refs #3192 forgot this file!

@diosmosis
Piwik Open Source Analytics member

(In [6679]) Refs #3275 & refs #3192, added report metadata for visits by day of week report and added said report as widget. Also moved code that removed filter_limit/offset params for graphs so related reports wouldn't be affected by #3192 bug.

@mattab mattab added this to the 1.8.3 - Piwik 1.8.3 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.