Plugins API: let plugins customize datatable footer icons #3317

Closed
chmielot opened this Issue Aug 13, 2012 · 8 comments

3 participants

@chmielot

Use case:

Using Widgetize-Plugin to display certain widgets on a website:

<div id="widgetIframe">
<iframe width="100%" 
    height="350" 
    src="http://host/piwik/index.php?module=Widgetize&action=iframe&columns[]=nb_visits,nb_pageviews&moduleToWidgetize=VisitsSummary&actionToWidgetize=getEvolutionGraph&idSite=1&period=month&date=today&disableLink=1&widget=1&show_export_as_image_icon=0" 
    scrolling="no" 
    frameborder="0" 
    marginheight="0" 
    marginwidth="0" 
    id="visitssum"></iframe>
</div>

The show_export_as_image_icon setting has no effect, because the value (first set in parent class from request parameters) is overwritten in core/ViewDataTable/GenerateGraphHTML.php

I don't see why this shouldn't be allowed here. The patch fixes this problem.

@chmielot

Please review

@mattab
Piwik Open Source Analytics member

So, do you want to be able to hide the "Export as image button" ? is it what you are requesting? we could add a new parameter "showExportAsImage".

See similar #3316

@chmielot

matt, this patch just fixes available functionality. Could be of course, that the existing show_export_as_image_icon parameter is deprecated. #3316 adds completely new functionality. Please also see #3327, which is similar.

@mattab
Piwik Open Source Analytics member

Generalizing the task so we can check that all features/icons of the datatable are customized by plugins reusing the Piwik framework.

@anonymous-piwik-user

In 83261e0: Refs #4041, #3317, #4077, allow different visualizations to specify their own loading logic (when the appropriate footer icon is clicked) and fix a couple UI bugs in treemap.

@anonymous-piwik-user

In c0768bf: Refs #4041, #3317, allow visualization ID to be whole class name, allow footer icons to be customized per report/visualization, made visitor log a new visualization and removed the datatable_template display property.

@anonymous-piwik-user

In 6042103: Fixes #3317, allow plugins/themes to specify their own ViewDataTable footer icons or modify existing ones.

@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4041, #3317, #4077, allow different visualizations to specify t…
…heir own loading logic (when the appropriate footer icon is clicked) and fix a couple UI bugs in treemap.
83261e0
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4041, #3317, allow visualization ID to be whole class name, all…
…ow footer icons to be customized per report/visualization, made visitor log a new visualization and removed the datatable_template display property.
c0768bf
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Fixes #3317, allow plugins/themes to specify their own ViewDataTable …
…footer icons or modify existing ones.
6042103
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment