Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Evolution Graph displays "no data" if last date has no data #3465

Closed
tsteur opened this Issue · 11 comments

4 participants

@tsteur
Owner

I tried to test evolution graph with "period=range". For example from 8th August 2012 to 2nd September 2012. It renders a graph displaying "No data for this graph" if there are no visits/actions on the last day of the period. If I set range from 8th August 2012 to 3rd September 2012, it dispalys the graph. There are actions and visits in August. It seems just to depend whether there are actions/visits on the last day.

When the graph is displayed with message "No data for this graph", the graph is also loading fast. Maybe it just looks at the last day and does no further queries in this case.

Manage this edge case when there is no data. This happens with any period, not only range.

See #3158
and #3158

@mattab
Owner

xhprof use is related to #3464

@diosmosis
Collaborator

In 930ec65: Refs #3465, use bulk tracking in RowEvolution integration test to speed it up.

@diosmosis
Collaborator

In 80ac6ac: Refs #3465, remove Piwik_DataTable_Array::metadata and move data to Piwik_DataTable::metadata.

@diosmosis
Collaborator

In 900eec1: Refs #3465, fixing build

@JulienMoumne
Collaborator

duplicate of #3790

@mattab
Owner

@JulienM wrote in #3790:

Since 3013 the Row Evolution API can be called to retrieve the top N label evolutions.

As suggested in 3158#comment:12, when there are less than 5 labels for the requested period, "top up" the labels list by requesting the report for the current year of data.

@diosmosis
Collaborator

In 51b7787: Fixes #3465, refactor row evolution code to fix bug where if no labels are specified and last period has no labels, no data is returned. Refactoring also contains optimization for case where no labels are specified.

Notes:

  • Simplified DataTableManipulator and derived classes.
  • Allow LabelFilter to use multiple labels. Can be used by specifying array for label query parameter (ie, label[]=...).
  • Removed getFilteredTableFromLabel function from datatable types and add getEmptyClone to DataTable_Array.
  • Added setIdSite to php tracker PiwikTracker.
@diosmosis
Collaborator

In d9ff500: Refs #3465, fix regression in multi row evolution API output where columns w/ value of 0 were not outputted.

@diosmosis
Collaborator

In 7a89c65: Refs #3465, make sure labels are associated with correct rows in multi-row evolution after generic filters (ie, Sort) are applied.

@diosmosis
Collaborator

In 204cbc0: Refs #3465, fix regression for flattener filter where queued filters were applied on the flattened datatable.

@diosmosis
Collaborator

In a8420c0: Refs #3465, fixing build.

@tsteur tsteur added this to the 1.12 - The Great 1.x Backlog milestone
@diosmosis diosmosis was assigned by tsteur
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.