GeoIP fails silently when mbstring extension not available #3473

Closed
mattab opened this Issue Oct 23, 2012 · 1 comment

2 participants

@mattab
Piwik Open Source Analytics member

Reported in forums.

We should

  • Remove silent fail @ operator in all GeoIP drivers
  • Update the System check, to add a warning that, when the extension mbstring is not available or enabled, geoIP will not work
  • It would be nice & important to ensure that, any error happening during GeoIP tracking, would alos be surfaced in the GeoIP tooltips on the admin page, so that users can see the errors in the UI and do not have to debug the tracking requests to see the errrors.
@diosmosis
Piwik Open Source Analytics member

(In [7290]) Fixes #3473, add "GeoIP won't work" warning to installation system check for mbstring, make sure GeoIP (Php) implementation checks for mbstring plugin, and remove silent fail calls in GeoIP plugins.

@mattab mattab added this to the 1.9.1 - Piwik 1.9.1 milestone Jul 8, 2014
@diosmosis diosmosis was assigned by mattab Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment