Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

GeoIP fails silently when mbstring extension not available #3473

Closed
mattab opened this Issue · 1 comment

2 participants

@mattab
Owner

Reported in forums.

We should

  • Remove silent fail @ operator in all GeoIP drivers
  • Update the System check, to add a warning that, when the extension mbstring is not available or enabled, geoIP will not work
  • It would be nice & important to ensure that, any error happening during GeoIP tracking, would alos be surfaced in the GeoIP tooltips on the admin page, so that users can see the errors in the UI and do not have to debug the tracking requests to see the errrors.
@diosmosis
Collaborator

(In [7290]) Fixes #3473, add "GeoIP won't work" warning to installation system check for mbstring, make sure GeoIP (Php) implementation checks for mbstring plugin, and remove silent fail calls in GeoIP plugins.

@mattab mattab added this to the 1.9.1 - Piwik 1.9.1 milestone
@diosmosis diosmosis was assigned by mattab
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.