Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

import_logs.py triggering "Warning: urldecode() expects parameter 1 to be string, array given in core/Tracker/Action.php on line 974" #3523

Closed
cbay opened this Issue · 4 comments

2 participants

Cyril B. Matthieu Aubry
Cyril B.
Collaborator

And import_logs fails because of this PHP warning (as it makes sure the response is a GIF file).

Using Piwik 1.9.1. To reproduce:

curl http://localhost/piwik.php --data '{"requests": ["1", "cdt": "2012-10-10 15:15:52", "urlref": "", "dp": "1", "url": "http://example.org/?s[]({"apiv":)=foo", "cip": "127.0.0.1", "idsite": 42, "rec": "1", "bots": "1", "ua": ""}], "token_auth": "foo"}'

See the URL? The '[]' is triggering the bug. Removing it makes the bug go away.

Sure, I can hide PHP warnings, but it would be nice to handle this properly as we cannot expect our users to hide warnings.

Matthieu Aubry
Owner

Can you please try with latest beta (which is morestable than 1.9.1): http://builds.piwik.org/piwik-1.9.2-b3.zip

I cant reproduce this bug with latest beta but if you still can let me know or re-open the ticket.

Cyril B.
Collaborator

Yes, I can reproduce it with 1.9.3-b3:

<b>Warning</b>: urldecode() expects parameter 1 to be string, array given in <b>/data/www/piwik2/core/Tracker/Action.php</b> on line <b>977</b>

Matthieu Aubry
Owner

(In [7411]) Fixes #3523 Please confirm the fix works for you! I couldnt reproduce the warning for some reasons

Cyril B.
Collaborator

It is indeed fixed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.