Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

GoalManager: misspelled variable leads to incorrect attribution #3550

Closed
christianfutterlieb opened this Issue · 4 comments

3 participants

Christian Futterlieb Anthon Pang Matthieu Aubry
Christian Futterlieb

To me it seems very likely that this is not wanted. Because with the uninitialized variable
$refererCampaignName
Campaign data are always taken from
$visitorInformation
(if
$visitorInformation
has a campaign registered). Please take a look at the patch.

Anthon Pang
Collaborator

(In [7485]) fixes #3550 referrerCampaignName typo; thanks Christian

Matthieu Aubry
Owner

oh very cool find, thanks so much, this bug was reported over the last months and I never found the cause, Cheers! Please keep patches like this coming ;-)

Christian Futterlieb

!^!^ .. I'm glad to be able to give something back

Christian Futterlieb christianfutterlieb added this to the 1.10 - Piwik 1.10 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.