Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Disabled Transitions Plugin leads to javascript error #3701

Closed
anonymous-piwik-user opened this Issue · 8 comments

4 participants

Anonymous Piwik user Matthieu Aubry Timo B. Benaka
Anonymous Piwik user

If the transitions plugin is disabled you are getting a javascript error on most pages in the piwik ui:

ReferenceError: DataTable_RowActions_Transitions is not defined

...createInstance:function(dataTable){return new DataTable_RowActions_Overlay(dataT...

(Version 1.10.1)

Matthieu Aubry
Owner

Thanks for the report!

Timo B.
Collaborator

The Overlay plugin depends on the Transitions plugin.

If want to you disable Transitions, you have to disable Overlay too. That should fix it. Can you try?

Anonymous Piwik user

sorry but that's not the point.
I had transitions disabled before, upgraded to a newer version where suddenly overlay was enabled - and nothing worked anymore because of javascript errors.
It took me a while to debug where these were coming from.
So please either:

  • automatically enable transitions when you automatically enable the overlay plugin
  • disable the overlay plugin when transitions are not enabled

It doesn't make much sense to have them separately enabled/disabled if the dependencies are not handled automatically.

Matthieu Aubry
Owner

This was reported also in #3737

Anonymous Piwik user

I disabled Overlay plugin, and after a force reload it works ok. Thanks for the tip.

But why Overlay plugin is suddenly enabled? I don't want it and didn't know piwik adds and enables plugins during updates. Now I have to browse plugin list and disable other plugins that appeared since I first installed piwik.

Matthieu Aubry
Owner

Good point, we also could write a message in the Update screen, with the list of newly enabled plugins.

Matthieu Aubry
Owner

In 3f35263: Refs #3701 adding simple message in UI

Benaka
Collaborator

In 19e35c0: Fixes #3701, check whether transitions plugin is loaded before showing overlay icon in datatable.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.