Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Display browser language of the visitors #3726

Closed
sgiehl opened this Issue · 15 comments

3 participants

@sgiehl
Collaborator

Browser language setting is already tracked for every visitor.
That data should also be available within the frontend.

@halfdan
Collaborator

I agree that this is interesting. Right now though, we don't even store the data in the 1st normal form (e.g. de-de,de,en-us,en).

Sometimes we have multiple occurences of the same language, e.g. de-de,de,en-us,en - which one is important here? de-de or de? Are they the same? What about en, en-gb and en-us?

What is important here? Should we just count the first language or all in the list? Should we build multiple statistics like "First Browser Language", "Second Browser Language"?

Ideas?

@sgiehl
Collaborator

I guess the main language should be enough for most users.
Btw. I'm already on that. Guess I'll finish that by the end of the week...

@halfdan
Collaborator

Ah nice! Good to know, almost started with it myself :)

@mattab
Owner

Only first language of the list, to keep things simple I think.

We could alternatively look at secondary languages if the first one is en-us for example, because I know lots of browsers ship by default with en-us settings and users don't necessarily change it.

@sgiehl
Collaborator

In 3f49038: refs #3726 adding reports for browser language of visitors

@sgiehl
Collaborator

In d1546c5: refs #3726 small test for method to get language from browser setting

@sgiehl
Collaborator

In abce17a: refs #3726 fixing test

@sgiehl
Collaborator

In b2aeb6a: refs #3726 added language names to translations

@sgiehl
Collaborator

In 74ff8ea: refs #3726 small improvements to detection method

@sgiehl
Collaborator

In e29d059: refs #3726 fixing some integration tests

@halfdan
Collaborator

Thanks! :-) I was scratching my head for the last 5 minutes and wondered why tests were suddenly failing on Travis..

@sgiehl
Collaborator

In 952dbcd: refs #3726 fixing integration test files

@mattab
Owner

Very nice changes!

Code review:

  • Some of the new code in: Piwik_UserSettings::_getLanguageCodeFromBrowserSetting is redundant with existing code in: Piwik_Common::extractCountryCodeFromBrowserLanguage I think both should use same logic ?
@mattab
Owner

In 2826710: small refactor refs #3726

@sgiehl
Collaborator

In 09bdded: fixes #3726 use Piwik_Common::extractLanguageCodeFromBrowserLanguage instead of new method to get language code

@sgiehl sgiehl added this to the 1.11 - Piwik 1.11 milestone
@sgiehl sgiehl self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.