Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

import_logs.py needs upgrade to Python 3 or updated shebang line #3759

Open
anonymous-piwik-user opened this Issue · 7 comments

3 participants

Anonymous Piwik user Matthieu Aubry J.M. Porup
Anonymous Piwik user

Some distributions like Arch have /usr/bin/python point to python3, not Python 2.x. Even more popular distributions are transitioning to do the same thing. Currently, the import-logs.py script does not work under Python 3. As such, either it should be updated to support Python 3, either its shebang line should be changed to #!/usr/bin/python2 instead of assuming that /usr/bin/python is Python 2.x.
Keywords: log-analytics, python

Matthieu Aubry
Owner

sounds like a very good idea to make it python 3 compatible. Please send pull request if you manage this (btw is it possible to keep compatibility with Python 2.6?)

Matthieu Aubry mattab removed the P: normal label
J.M. Porup

This issue blocks the use of the log-analytics script over HTTPS on Gandi, whose SNI config requires python 3.2+.

Since I don't want to expose my logs over a cleartext connection, that means I can't use the log-analytics script. :(

Here is what Gandi support told me:

But here is the problem. When executing the script import_log.py with python 3.2 a syntax error is returned as you can see it below:

$ ./import_logs.py --url=https://piwik.rimk.me/ ~/var/log/apache/access.log --debug

File "import_logs.py", line 562
except Piwik.Error, e:
^
SyntaxError: invalid syntax

Matthieu Aubry
Owner

Hi @JMPorup AFAIK it's not possible for script to support both Python 2 and python 3 unfortunately, and we must support Python 2.x still

J.M. Porup

@mattab how much work is it to update the script to python 3? Perhaps fork the log-analytics script into log-analytics-python2 and log-analytics-python3 ?

Matthieu Aubry
Owner

@JMPorup no idea...

J.M. Porup

@mattab Would you please consider looking into it? This is a major showstopping bug for me, and no doubt for many others as well. As it is, Gandi no longer recommends Piwik to their users because of this bug!

Matthieu Aubry
Owner

@JMPorup sorry, we can't. we don't have enough resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.