Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

API: new segment 'siteSearchKeyword' to match visitors who made a particular Site Search request #3904

Closed
mattab opened this Issue · 1 comment

1 participant

Matthieu Aubry
Matthieu Aubry
Owner

Let's add a new segment 'siteSearchKeyword' and remove one TODO from the codebase, FTW

See the very useful Site Search reports feature!

Matthieu Aubry
Owner

In 35f975a: Fixes #3904:

  • new segment 'siteSearchKeyword' Fixes #3903, #3905:
  • adding few fields in the Live API output to accomodate getSuggestedValuesForSegment
  • renamed other fields for consistency with segment names Fixes #3906:
  • new API: getSuggestedValuesForSegment which returns top suggested values for a particular segment. It uses the Live.getLastVisitsDetails API to fetch the most recently used values, and will show the most used values first

  • Adding tests for everything. The test case actually generates data for all segments so that VisitsSummary.get returns some data for each of the 47 segments being tested returns some data.
    How it works:

    • generate extended data in fixture
    • Tests (1) call getSuggestedValuesForSegment for each segment, check there is some data returned for each segment
    • get the first suggested value from the list,
    • Tests (2) call VisitsSummary.get with this segment value, eg. countryCode==ru.
      • I worked this way for all 47 segments until all tests had some data ==> now we know that all segments have been tested and that the auto suggest works for all segments. TDD FTW!
Matthieu Aubry mattab added this to the 1.12 - The Great 1.x Backlog milestone
Matthieu Aubry mattab self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.