Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

When visitors are recorded in a random chronological order, Piwik should assign the actions correctly #3927

Closed
mattab opened this Issue · 1 comment

1 participant

@mattab
Owner

This is a feature request from Takeshi, piwikjapan.org webmaster. It had been requested by other users before: allow Piwik to import recent visitors, then old visits from the same visit and record them in the past.

When importing log files in random order, the visits are recorded for the last visitor instead of being recorded each day as we would expect. This happens because the "get visit" query does not restrict the "max date". So when recording an old visitor, if "new visits" from this same visitor have already been recorded, the algorithm would select this "new" visit row instead of creating a visit for the past date.

I will fix this by adding a test case and putting in simple solution.

This is follow up of #2584

@mattab
Owner

In 56554b5: Fixes #3927
Adding future look ahead window to the SQL trying to detect the current visitor

  • fixing small bug discovered (in the tests) as a result of this fix
@mattab mattab added this to the 1.12 - The Great 1.x Backlog milestone
@mattab mattab self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.