Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

API method API.getBulkRequest converts whitespace to HTML entities #3970

Closed
tsteur opened this Issue · 5 comments

2 participants

@tsteur
Owner

Hi,

I'm displaying some properties from Live.getLastVisitDetails in Mobile App. When requesting this method via BulkRequests, it converts some content to HTML entities.

timeSpentPretty: "2 min 8s"

For instance visitDurationPretty and timeSpentPretty . I cannot reproduce this behavior when executing plain Live.getLastVisitDetails action (no BulkRequest).

In Mobile App I cannot resolve HTML entities. Can we either not convert anything or convert them to Unicode (\u0000)?

Plain request (replace token_auth to reproduce):
http://demo.piwik.org/?module=API&method=Live.getLastVisitsDetails&idSite=1&period=day&date=today&format=JSON&token_auth=XXXXXXX

With BulkRequest (replace token_auth to reproduce):
http://demo.piwik.org/index.php?urls%5B0%5D=method%3dLive.getCounters%26lastMinutes%3d30%26format%3dJSON%26idSite%3d1%26&urls%5B1%5D=method%3dLive.getCounters%26lastMinutes%3d1440%26format%3dJSON%26idSite%3d1%26&urls%5B2%5D=method%3dLive.getLastVisitsDetails%26filter_limit%3d20%26period%3dday%26date%3dtoday%26format%3dJSON%26idSite%3d1%26&module=API&date=today&token_auth=XXXXXXXXXX&period=day&format=json&method=API.getBulkRequest&language=en&

@mattab
Owner

I know this is not an acceptable answer :p but what about such function? http://stackoverflow.com/questions/5796718/html-entity-decode/9609450#9609450

@tsteur
Owner

Yes, not acceptable :) I do not have a DOM in native mobile app ;) And we should avoid as much computation on mobile as possible ;)

@tsteur
Owner

In 229e04c: refs #3970 this should fix html entities are returned in json output

@tsteur
Owner

In 9206f7d: refs #3970 this should fix some bulk requests are not correct rendered because there is an array of dataTables

@tsteur
Owner

In 68b8ccb: refs #3970 probably a better fix for html entities in json output, fixes bulkRequest is buggy with PHP and other renderers

@tsteur tsteur added this to the 2.0 - Piwik 2.0 milestone
@tsteur tsteur self-assigned this
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@tsteur tsteur refs #3970 this should fix some bulk requests are not correct rendere…
…d because there is an array of dataTables
9206f7d
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@tsteur tsteur refs #3970 probably a better fix for html entities in json output, fi…
…xes bulkRequest is buggy with PHP and other renderers
68b8ccb
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.