Skip to content

Loading…

Incorrect define() signature #3975

Closed
anonymous-piwik-user opened this Issue · 7 comments

3 participants

@anonymous-piwik-user

piwik.js

change:

define(["piwik"],[],

to:

define("piwik",[],

The module name should not be wrapped in brackets. It should be passed as a string; not an array.
Keywords: define amd

@robocoder

In 0858888: fixes #3975

@robocoder

In 98adc6a: fixes #3975

@anonymous-piwik-user

This issue breaks existing websites that use RequireJS when Piwik is loaded async (which it is by default).

Uncaught Error: Mismatched anonymous define() module: 
http://requirejs.org/docs/errors.html#mismatch require.js:160
makeError require.js:160
intakeDefines require.js:1191
(anonymous function)

When piwik.js is evaluated before require.js, this stops loading other modules, instead of giving only an error.

Perhaps it is a good idea to release Piwik 1.12.1 with the provided fix?

@robocoder

Already committed to the 1.x maintenance branch.

@anonymous-piwik-user

bug still present in current 1.12 - had to patch manually

@mattab
Piwik Open Source Analytics member

Can you confirm it works in 2.0 ? https://piwik.org/blog/2013/10/new-piwik-2-0-public-beta-for-testers/

If not please suggest how to fix it, cheers

@anonymous-piwik-user

It's fixed. Thanks.

@anonymous-piwik-user anonymous-piwik-user added this to the 2.0 - Piwik 2.0 milestone
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@robocoder robocoder fixes #3975 0858888
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.