Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update ExampleUI plugin with latest widget APIs #3994

Closed
mattab opened this Issue · 16 comments

2 participants

Matthieu Aubry Thomas Steur
Matthieu Aubry
Owner

ExampleUI plugin is a nice tool, we should update it to work with latest widget API (and fix the bar graph which does not display)

In general, does this plugin make it clear to developers what Piwik Framework offers in terms of using the framework to display custom data?

See also: #4124 Display a custom date-based dataset in a simple Piwik Plugin

Thomas Steur
Owner

In 2294b38: refs #3994 coding style, removed unused code

Thomas Steur
Owner

In 7eb6a2b: refs #3994 do not display metric visits and actions

Thomas Steur
Owner

In f689733: refs #3994 evolution graph failed to load if DataTable object is given

Thomas Steur
Owner

In 11d2794: refs #3994 added example for evolution graph

Thomas Steur
Owner

In 896d110: refs #3994 this fixes percentage values are always 0 in pie graphs

Thomas Steur
Owner

In 852513d: refs #3994 fix the evolution graph is sorted by value if only one metric is selected

Thomas Steur
Owner

I think this is done. Any other ideas?

Thomas Steur
Owner

In a963a87: refs #3994 allow only one metric

Thomas Steur
Owner

In 955ef7c: refs #3994 this is an example how to make a customized existing visualization reusable

Thomas Steur
Owner

In c730967: refs #3994 gives some autocompletion to viewdatatable properties

Thomas Steur
Owner

In 5c30547: refs #3994 auto completion for visualization properties

Thomas Steur
Owner

In ec6de8c: refs #3994 use table as default type

Matthieu Aubry
Owner

Feedback:

  • nice changes!
  • add Column documentation for the "Temperature in C" column (on hover)
  • in Tag Clouds menu, there is a " Previous " link display but shouldn't be
  • Limit selector does not work on Evolution Graph (error is "The parameter 'columns' isn't set in the Request, and a default value wasn't provided.")
  • CustomDataTable should be called CustomViewDataTable maybe? or maybe CustomDataTableView?
Thomas Steur
Owner

In 6a3d27b: refs #3994 do not create a separate class for this example

Thomas Steur
Owner

In 2192359: refs #3994 added dummy documentation for temperature metric

Matthieu Aubry mattab added this to the 2.0 - Piwik 2.0 milestone
Thomas Steur tsteur was assigned by mattab
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Thomas Steur tsteur refs #3994 coding style, removed unused code 2294b38
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Thomas Steur tsteur refs #3994 do not display metric visits and actions 7eb6a2b
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Thomas Steur tsteur refs #3994 added example for evolution graph 11d2794
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Thomas Steur tsteur refs #3994 fix the evolution graph is sorted by value if only one met…
…ric is selected
852513d
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Thomas Steur tsteur refs #3994 allow only one metric a963a87
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Thomas Steur tsteur refs #3994 this is an example how to make a customized existing visua…
…lization reusable
955ef7c
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Thomas Steur tsteur refs #3994 auto completion for visualization properties 5c30547
Philip Taffner sabl0r referenced this issue from a commit in sabl0r/piwik
Thomas Steur tsteur refs #3994 use table as default type ec6de8c
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.