Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Make PDF Reports Truncation limit configurable in config file #4009

Closed
BeezyT opened this Issue · 2 comments

2 participants

@BeezyT
Collaborator

In Piwik_PDFReports_API.generateReport, $_GET['filter_truncate'] is set to self::REPORT_TRUNCATE = 23.

The comment is:

the report will be rendered with the first 23 rows and will aggregate other rows in a summary row
23 rows table fits in one portrait page

There are two problems with this

  • People might want more than 23 rows in their PDF reports
  • The truncation in not necessary when rendering a HTML report or a portrait page
@BeezyT
Collaborator

In 668111b: refs #4009 making the number of rows after which the PDFReports plugin truncates configurable.

this does not fix the ticket since it still would be nice if the truncation would be a little more intelligent. i.e. using different values for landscape / portrait and/or not truncating at all in HTML view.

julien, if you disagree, feel free to close the ticket. it's just a suggestion and i fixed the part that caused trouble for me so i'm fine either way.

@mattab
Owner

Narrowing scope, it's fixed!

@BeezyT BeezyT added this to the 2.0 - Piwik 2.0 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.