Allow ViewDataTables to be rendered via metadata alone #4040

Closed
diosmosis opened this Issue Jul 8, 2013 · 32 comments

3 participants

@diosmosis
Piwik Open Source Analytics member

Related to #1491.

Should be possible to define a set of display properties for a report and have ViewDataTable automatically render based on those properties. This would replace the current method of manually creating a ViewDataTable instance and calling setXXX and disableYYY functions on it before rendering.

@anonymous-piwik-user

In 0105777: Refs #4040, #4041, move all ViewDataTable properties to the viewProperties array and allow these properties to be specified through new display metadata. Converted the Actions, Goals, UserSettings and VisitTime controllers.

Notes:

  • Includes refactoring of ExcludeLowPopulation filter.
@anonymous-piwik-user

In d99e37e: Refs #4040, Modify getReportDisplayProperties to add display properties for all of a plugin's reports to a list rather than to pick out the display properties for a single report.

@anonymous-piwik-user

In 80c4b46: Refs #4040, converted CustomVariables plugin to use display properties instead of manually calling ViewDataTable functions.

@anonymous-piwik-user

In d056230: Refs #4040, converted DBStats plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user

In a5bbfbf: Refs #4040, convert DevicesDetection plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user

In 9b02615: Refs #4040, move Piwik_ViewDataTable::getRawSegmentFromRequest to Piwik_API_Request.

@anonymous-piwik-user

In f1dcb45: Refs #4040, converted Live plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user

In b298983: Refs #4040, convert Provider plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user

In 02e0be4: Refs #4040, converted Referrers plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user

In 4e3a67a: Refs #4040, converted UserCountry plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user

In 228a6aa: Refs #4040, converted VisitorInterest plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user

In edf2c04: Refs #4040, #4041, added ability to access view properties directly, started documenting view properties and modified ExampleUI plugin to set view properties directly.

@anonymous-piwik-user

In 0ea1a94: Refs #4040, #4041 convert RowEvolution popup rendering code to set view properties directly.

@anonymous-piwik-user

In 13f657c: Refs #4040, #4041, fix sparklines regression caused by datatable css refactoring and clean up the getLastUnitGraphAcrossPlugins function (modified to set properties directly).

@anonymous-piwik-user

In 0f61caa: Refs #4040, #4041 removed rest of viewdatatable set/get/enable/disable property functions, did the same for all other ViewDataTable classes, moved most of ViewDataTable/HtmlTable logic to visualization instead of main class and re-add links for UI integration tests.

@anonymous-piwik-user

In 883c322: Refs #4040, #4041, move more logic out of HtmlTable ViewDataTable class.

@anonymous-piwik-user

In 1a9898b: Refs #4040, #4041, fix regression in default sort column of goals table.

@anonymous-piwik-user

In 7519e67: Refs #4040, #4041, move AllColumns ViewDataTable & Goals ViewDataTable logic to HtmlTable visualization class & remove those classes. Revised the way visualizations default/override view properties. Cleaned up the ViewDataTable class a bit. Added base type for datatable visualizations.

@anonymous-piwik-user

In b808489: Refs #4040, #4041, remove is_multi_evolution javascript parameter as it is no longer necessary due to earlier row evolution refactoring.

@anonymous-piwik-user

In cc92fac: Refs #4040, #4041, remove GenerateGraphHtml & descended ViewDataTables and replace w/ new visualizations for jqplot.

@anonymous-piwik-user

In ac3a25c: Refs #4040, #4041, forgot to remove GenerateGraphHTML file.

@anonymous-piwik-user

In cf8d0a5: Refs #4041, #4040, moved viewdatatable cloud logic to cloud visualization. Removed cloud viewdatatable.

@anonymous-piwik-user

In 2615404: Refs #4040, #4041, move visualization only view properties to separate visualizations, changed JavaScript properties to 'client side parameters' and 'overridable properties' to 'client side properties', changed keep_summary_row from a JavaScript property to a client side property, allowed visualization properties to be inherited, fixed system that allowed visualizations to set custom defaults for property values, modified behavior of datatable_css_class viewdatatable property, allow view properties to be customized in metadata based on the visualization used, and tweaks to UI Integration tests.

@anonymous-piwik-user

In 9b5a42a: Refs #4040, #4041, change the way jqplot.js checks for viewdatatble types, changed relatedReports view property name to related_reports and fixed spelling of row_picker_mach_rows_by.

@anonymous-piwik-user

In e898bc2: Refs #4040, #4041 add initial code for making datatable visualizations an extensibility point.

@anonymous-piwik-user

In 9e19f24: Refs #4041, #4040 add new CoreVisualizations plugin and move HtmlTable, Cloud & JqplotGraph visualizations to it and improve UIIntegration test debug output.

@anonymous-piwik-user

In be35dc4: Refs #4040, #4041, removed ViewDataTable::init & moved default property values for core properties to Properties class.

@anonymous-piwik-user

In 7daadd4: Refs #4040, #4041 added new plugin ExtraVisualizations with dummy visualization and made it possible for non-core visualizations to appear in DataTable UI footer.

@anonymous-piwik-user

In 6f8b40d: Refs #4040, #4041, added documentation to DataTableVisualization class.

@anonymous-piwik-user

In 27dcd70: Refs #4040, #4041, removed two-phase rendering for ViewDataTable.

@diosmosis
Piwik Open Source Analytics member

Done.

@mattab
Piwik Open Source Analytics member

Nice work and refactoring! we will discuss with team their opinion and where we can take it next. Keep it up!

@diosmosis diosmosis added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, move all ViewDataTable properties to the viewPrope…
…rties array and allow these properties to be specified through new display metadata. Converted the Actions, Goals, UserSettings and VisitTime controllers.

Notes:
  - Includes refactoring of ExcludeLowPopulation filter.
0105777
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, Modify getReportDisplayProperties to add display properti…
…es for all of a plugin's reports to a list rather than to pick out the display properties for a single report.
d99e37e
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, converted CustomVariables plugin to use display propertie…
…s instead of manually calling ViewDataTable functions.
80c4b46
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, converted DBStats plugin to use display properties instea…
…d of ViewDataTable methods.
d056230
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, convert DevicesDetection plugin to use display properties…
… instead of ViewDataTable methods.
a5bbfbf
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, move Piwik_ViewDataTable::getRawSegmentFromRequest to Piw…
…ik_API_Request.
9b02615
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, converted Live plugin to use display properties instead o…
…f ViewDataTable methods.
f1dcb45
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, convert Provider plugin to use display properties instead…
… of ViewDataTable methods.
b298983
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, converted Referrers plugin to use display properties inst…
…ead of ViewDataTable methods.
02e0be4
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, converted UserCountry plugin to use display properties in…
…stead of ViewDataTable methods.
4e3a67a
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, converted VisitorInterest plugin to use display propertie…
…s instead of ViewDataTable methods.
228a6aa
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, added ability to access view properties directly, …
…started documenting view properties and modified ExampleUI plugin to set view properties directly.
edf2c04
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041 convert RowEvolution popup rendering code to set vi…
…ew properties directly.
0ea1a94
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, fix sparklines regression caused by datatable css …
…refactoring and clean up the getLastUnitGraphAcrossPlugins function (modified to set properties directly).
13f657c
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041 removed rest of viewdatatable set/get/enable/disabl…
…e property functions, did the same for all other ViewDataTable classes, moved most of ViewDataTable/HtmlTable logic to visualization instead of main class and re-add links for UI integration tests.
0f61caa
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, move more logic out of HtmlTable ViewDataTable class. 883c322
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, fix regression in default sort column of goals table. 1a9898b
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, move AllColumns ViewDataTable & Goals ViewDataTabl…
…e logic to HtmlTable visualization class & remove those classes. Revised the way visualizations default/override view properties. Cleaned up the ViewDataTable class a bit. Added base type for datatable visualizations.
7519e67
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, remove is_multi_evolution javascript parameter as …
…it is no longer necessary due to earlier row evolution refactoring.
b808489
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, remove GenerateGraphHtml & descended ViewDataTable…
…s and replace w/ new visualizations for jqplot.
cc92fac
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, forgot to remove GenerateGraphHTML file. ac3a25c
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4041, #4040, moved viewdatatable cloud logic to cloud visualiza…
…tion. Removed cloud viewdatatable.
cf8d0a5
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, move visualization only view properties to separat…
…e visualizations, changed JavaScript properties to 'client side parameters' and 'overridable properties' to 'client side properties', changed keep_summary_row from a JavaScript property to a client side property, allowed visualization properties to be inherited, fixed system that allowed visualizations to set custom defaults for property values, modified behavior of datatable_css_class viewdatatable property, allow view properties to be customized in metadata based on the visualization used, and tweaks to UI Integration tests.
2615404
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, change the way jqplot.js checks for viewdatatble t…
…ypes, changed relatedReports view property name to related_reports and fixed spelling of row_picker_mach_rows_by.
9b5a42a
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041 add initial code for making datatable visualization…
…s an extensibility point.
e898bc2
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4041, #4040 add new CoreVisualizations plugin and move HtmlTabl…
…e, Cloud & JqplotGraph visualizations to it and improve UIIntegration test debug output.
9e19f24
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, removed ViewDataTable::init & moved default proper…
…ty values for core properties to Properties class.
be35dc4
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041 added new plugin ExtraVisualizations with dummy vis…
…ualization and made it possible for non-core visualizations to appear in DataTable UI footer.
7daadd4
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, added documentation to DataTableVisualization class. 6f8b40d
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Benaka Moorthi Refs #4040, #4041, removed two-phase rendering for ViewDataTable. 27dcd70
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment