Skip to content

Loading…

Remove the /.git test in the System Check file integrity #4047

Closed
oerdnj opened this Issue · 3 comments

2 participants

@oerdnj

Some people like to maintain the websites in the local git (for easy modifications, etc.), and it would be nice to have the ability to disable (in config.ini.php) this check:

--- Piwik.php   2013-06-25 08:22:23.054989006 +0200
+++ /git/piwik/core/Piwik.php   2013-05-30 10:57:06.000000000 +0200
@@ -625,10 +625,10 @@ class Piwik
         $messages[] = true;

         // ignore dev environments
-        // if (file_exists(PIWIK_INCLUDE_PATH . '/.git')) {
-        //    $messages[] = Piwik_Translate('General_WarningFileIntegritySkipped');
-        //    return $messages;
-        // }
+        if (file_exists(PIWIK_INCLUDE_PATH . '/.git')) {
+            $messages[] = Piwik_Translate('General_WarningFileIntegritySkipped');
+            return $messages;
+        }

         $manifest = PIWIK_INCLUDE_PATH . '/config/manifest.inc.php';
         if (!file_exists($manifest)) {

So I don't have to patch my instance (which in turn cries in the System Check that the files have been modified).

Thanks.

@mattab
Piwik Open Source Analytics member

.

@mattab
Piwik Open Source Analytics member

In 938271a: Fixes #4047 Just removing the test as it is actually not useful anymore (the manifest.inc.php test that follows is doing the job). thanks for the report!

@mattab
Piwik Open Source Analytics member

In 89a6a78: Refs #4047 Also removing the now unused translation (and removed from otrance)

@oerdnj oerdnj added this to the 2.0 - Piwik 2.0 milestone
@mattab mattab was assigned by oerdnj
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@mattab mattab Fixes #4047 Just removing the test as it is actually not useful anymo…
…re (the manifest.inc.php test that follows is doing the job). thanks for the report!
938271a
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@mattab mattab Refs #4047 Also removing the now unused translation (and removed from…
… otrance)
89a6a78
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.