Remove compat code for PHP < 5.3 #4113

Closed
halfdan opened this Issue Sep 3, 2013 · 10 comments

4 participants

@halfdan
Piwik Open Source Analytics member

We can clean the code base after raising the requirement to PHP 5.3.

There are some compat functions in core/IP.php because Windows with PHP < 5.3 did not provide inet_ntop/inet_pton.

@anonymous-piwik-user

In 3f7a679: Remove compat code for PHP < 5.3. inet_pton/inet_ntop are available in Windows in PHP >= 5.3 so we don't need the compat code anymore.

refs #3741, #4113

@anonymous-piwik-user

In d507de9: Remove more pre 5.3 compat code

refs #4113

@anonymous-piwik-user

In d2e842fbc3c70a7e2264ad978d1e36798f24a8a6: Remove upgradephp library

refs #4113

@halfdan
Piwik Open Source Analytics member

Reverted the last commit. upgradephp should be merged with core somehow. We don't need to upgrade some of the functions anymore.

Any reason for #1900? What's the point of not unserializing objects - as long as we don't execute anything we should be safe, right?

@anonymous-piwik-user

In f229dbc: Replace create_function calls with lambda functions.
This allows the IDE to pick up all code!

refs #4113

@halfdan
Piwik Open Source Analytics member

@vipsoft: Thanks for the info!

@mattab
Piwik Open Source Analytics member

Good to get it done for 2.0.

What is left on this ticket?

@halfdan
Piwik Open Source Analytics member

We need to check what we need from libs/upgradephp - there are some patches that Anthon mentioned above, but also some code that could be removed. So maybe we could merge the remainders into core.

There are also some functions in core (e.g. IP::N2P etc.) that could be removed.

@mattab
Piwik Open Source Analytics member

Could you simply list all functions you think should be deleted, in the ticket description, and I'll investigate for sure.

@halfdan halfdan added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@mattab mattab was assigned by halfdan Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan halfdan Remove compat code for PHP < 5.3. inet_pton/inet_ntop are available i…
…n Windows in PHP >= 5.3 so we don't need the compat code anymore.

refs #3741, #4113
3f7a679
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan halfdan Remove more pre 5.3 compat code
refs #4113
d507de9
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan halfdan Replace create_function calls with lambda functions.
This allows the IDE to pick up all code!

refs #4113
f229dbc
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment