Fix all Phpstorm php warnings in Inspection tool #4123

Closed
mattab opened this Issue Sep 6, 2013 · 6 comments

3 participants

@mattab
Piwik Open Source Analytics member

It is super useful to fix all Phpstorm php warnings in Inspection tool

eg since we do not have 100% code coverage, Phpstorm is amazingly helpful. Warnings == real bugs, eg. throw new Exception should be throw new \Exception

@tsteur
Piwik Open Source Analytics member

In 588d71a: refs #4123 fix some phpstorm inspection warnings

@tsteur
Piwik Open Source Analytics member

I think they are already fixed. Please reopen if not.

@mattab
Piwik Open Source Analytics member

In f5fc4ee: refs #4123 Removing some warnings

@mattab
Piwik Open Source Analytics member

In 186f09a: refs #4123 Removing unused imports (using phpstorm Inspections>Fix feature)

@mattab
Piwik Open Source Analytics member

In d1d4472: Refs #4123 Applying phpstorm "Organize imports" on core/* and plugins/* directories

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@tsteur tsteur was assigned by mattab Jul 8, 2014
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur tsteur refs #4123 fix some phpstorm inspection warnings 588d71a
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab refs #4123 Removing some warnings f5fc4ee
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab refs #4123 Removing unused imports (using phpstorm Inspections>Fix fe…
…ature)
186f09a
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab mattab Refs #4123 Applying phpstorm "Organize imports" on core/* and plugins…
…/* directories
d1d4472
@kalessil

Not sure if it's good idea to comment closed tickets, but there is a plugin for PhpStorm - really advanced inspections.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment