Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

API CHANGE: Plugin Referers now called Referrers #4125

Closed
mattab opened this Issue · 15 comments

3 participants

@mattab
Owner

Let's use the Piwik 2.0 release opportunity to rename some badly named plugins:

  • PDFReports becomes ScheduledReports
  • Referers becomes Referrers
@sgiehl
Collaborator

I've already renamed all translation keys accordingly.

@anonymous-piwik-user

In 1b2cf69: Refs #4125, add test case that makes sure blobs w/ Referers_ prefix are used if found.

@anonymous-piwik-user

In cefbc7f: Refs #4125, make Referers_... blob test less useless and move out of OneVisitorTwoVisitsTest.

@anonymous-piwik-user

In 0deb2bb: Refs #4125, rename Referers_... record names to Referrers and make sure code is backwards compatible.

@mattab
Owner

I vote for revert this change and instead:

  • rename all archive records from Referers to Referrers using Mysql REPLACE string function
  • This way data is consistent in the DB and we dont need to add the complex BC handler code
@mattab
Owner

In a27771e: Refs #4125 Renaming plugin from Referers to Referrers

  • updating all variables/methods containing Referers
  • RENAMING custom segments definition, and custom scheduled reports definition, so that when they load "Referers" segment/report it still works as expected
  • RENAMING old archived data so that archived blobs are called Referrers
    • Reverting part of 0deb2bb
    • Update integration tests generating PDF+HTML with images on my dev box (GD 2.1 and PHP 5.5)
@mattab
Owner

In 9e4842e: Refs #4125 Checking we still read old config values for truncation

@mattab
Owner

In 9ca63b0: Refs #4125 Renaming PDFReports to ScheduledReports

@mattab
Owner

In 4d3527c: Refs #4125 commit SQL Update file

@mattab
Owner

In e4f1bdd: Refs #4125 Fixes

@mattab
Owner

In b03211c: Refs #4125 renaming expected files

@mattab
Owner

In 64a7597: Refs #4125 adding backtick so it works if there is no prefix (where option is a mysql reserved keyword)

@mattab
Owner

In eeb705a: Making sure API calls using old Referers or PDFReports would still work by automatically loading the new plugin instead (kind of internal Redirects) refs #4125 #4219

@anonymous-piwik-user

This doesn't work. If you call "Referers" on API Version > 2.0.0 you get an error message. If you call the new word on old APIs you get an error message, too.

I fixed it for myself with checking the API version, but maybe this helps another people.

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone
@mattab mattab self-assigned this
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@diosmosis diosmosis Refs #4125, add test case that makes sure blobs w/ Referers_ prefix a…
…re used if found.
1b2cf69
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@diosmosis diosmosis Refs #4125, make Referers_... blob test less useless and move out of …
…OneVisitorTwoVisitsTest.
cefbc7f
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@diosmosis diosmosis Refs #4125, rename Referers_... record names to Referrers and make su…
…re code is backwards compatible.
0deb2bb
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4125 Renaming plugin from Referers to Referrers
 * updating all variables/methods containing Referers
 * RENAMING custom segments definition, and custom scheduled reports definition, so that when they load "Referers" segment/report it still works as expected
 * RENAMING old archived data so that archived blobs are called Referrers
  * Reverting part of 0deb2bb
  * Update integration tests generating PDF+HTML with images on my dev box (GD 2.1 and PHP 5.5)
a27771e
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4125 Renaming PDFReports to ScheduledReports 9ca63b0
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4125 commit SQL Update file 4d3527c
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4125 Fixes e4f1bdd
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4125 renaming expected files b03211c
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4125 adding backtick so it works if there is no prefix (where `…
…option` is a mysql reserved keyword)
64a7597
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Making sure API calls using old Referers or PDFReports would still wo…
…rk by automatically loading the new plugin instead (kind of internal Redirects) refs #4125 #4219
eeb705a
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.