Skip to content

Loading…

Review list of Event names, Piwik 2 plugin hooks #4134

Closed
mattab opened this Issue · 15 comments

3 participants

@mattab
Piwik Open Source Analytics member

Review hook names and make them consistent.

See suggestion in this doc https://docs.google.com/spreadsheet/ccc?key=0AvPareR6i0gfdFp4SUVNSy1qdE0zbTNhU3pRS0lLYnc#gid=0

@mattab
Piwik Open Source Analytics member

In d91d0d8: * Renaming getCssFiles hook to getStylesheetFiles

  • Renaming function names
  • Removing getCss and getJs from CoreHome module since they are expected in the Proxy module

Refs #4134

@tsteur
Piwik Open Source Analytics member

In e476ef0: refs #4134 renamed some hooks

@tsteur
Piwik Open Source Analytics member

In 43883bd: refs #4134 renamed hook

@tsteur
Piwik Open Source Analytics member

In 7b7df45: refs #4134 better name for constant after renaming the hook

@tsteur
Piwik Open Source Analytics member

In 7abaeb9: refs #4134 renamed template hooks

@tsteur
Piwik Open Source Analytics member

In 676327f: refs #4134 trigger general API event for all actions

@tsteur
Piwik Open Source Analytics member

In c19465f: refs #4134 added general event for controllers

@tsteur
Piwik Open Source Analytics member

In 2c5e854: refs #4134 renamed some more hooks

@tsteur
Piwik Open Source Analytics member

In f00d2f8: refs #4134 use plural to indicate a developer can add multiple entries or widgets

@tsteur
Piwik Open Source Analytics member

In cc422d3: refs #4134 added generic API hook

@tsteur
Piwik Open Source Analytics member

In f185beb: refs #4134 renamed some more hooks and removed some not used and not needed hooks

@halfdan
Piwik Open Source Analytics member

Is there a list of changed hooks? This would be important to have since people need to rewrite their plugins.

@tsteur
Piwik Open Source Analytics member

new: API.Request.dispatch
API.Proxy.processReturnValue --> API.Request.dispatch.end
ArchiveProcessing_Day.compute --> ArchiveProcessor.Day.compute
ArchiveProcessing_Period.compute --> ArchiveProcessor.Period.compute
AssetManager.filterMergedJs --> AssetManager.filterMergedJavaScripts
AssetManager.filterMergedCss --> AssetManager.filterMergedStylesheets
AssetManager.getJsFiles --> AssetManager.getJavaScriptFiles
FrontController.badConfigurationFile --> Config.badConfigurationFile
FrontController.NoConfigurationFile --> Config.noConfigurationFile
AdminMenu.add --> Menu.Admin.addItems
Menu.add --> Menu.Reporting.addItems
TopMenu.add --> Menu.Top.addItems
FrontController.dispatch --> Request.dispatch
new: Request.dispatch.end
FrontController.dispatchCoreAndPluginUpdatesScreen --> Request.dispatchCoreAndPluginUpdatesScreen
FrontController.initAuthenticationObject --> Request.initAuthenticationObject
Piwik.getKnownSegmentsToArchiveAllSites --> Segments.getKnownSegmentsToArchiveAllSites
Piwik.getKnownSegmentsToArchiveForSite --> Segments.getKnownSegmentsToArchiveForSite
Common.fetchWebsiteAttributes --> Site.getSiteAttributes
SitesManager.deleteSite --> SitesManager.deleteSite.end
template_footerUserCountry --> Template.footerUserCountry
template_footerVisitsFrequency --> Template.footerVisitsFrequency
template_headerVisitsFrequency --> Template.headerVisitsFrequency
template_leftColumnUserCountry --> Template.leftColumnUserCountry
template_nextToCalendar --> Template.nextToCalendar
template_reportParametersPDFReports --> Template.reportParametersPDFReports
template_topBar --> Template.topBar
Tracker.detectRefererSearchEngine --> Tracker.detectReferrerSearchEngine
Tracker.Visit.isExcluded --> Tracker.isExcludedVisit
Tracker.Action.record --> Tracker.recordAction
Tracker.setRequest.idSite --> Tracker.setSiteId
Tracker.Visit.setVisitorIp --> Tracker.setVisitorIp
Tracker.saveVisitorInformation --> Tracker.visitorInformation
FrontController.checkForUpdates --> Updater.checkForUpdates
Translate.getLanguageToLoad --> User.getLanguage
FrontController.NoAccessException --> User.isNotAuthorized
ViewDataTable.Visualization.getAvailable --> Visualization.addVisualizations
ViewDataTable.configureFooterIcons --> Visualization.configureFooterIcons
ViewDataTable.getReportDisplayProperties --> Visualization.getReportDisplayProperties
ViewDataTable.configureReportView --> Visualization.initView
WidgetsList.add --> WidgetsList.addWidgets
WidgetsList.get --> WidgetsList.getWidgets

@mattab
Piwik Open Source Analytics member

See also next step: #4199 Document Hook events

@tsteur
Piwik Open Source Analytics member
@mattab mattab added this to the 2.0 - Piwik 2.0 milestone
@tsteur tsteur was assigned by mattab
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@mattab mattab * Renaming getCssFiles hook to getStylesheetFiles
* Renaming function names
* Removing getCss and getJs from CoreHome module since they are expected in the Proxy module

Refs #4134
d91d0d8
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 renamed some hooks e476ef0
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 renamed hook 43883bd
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 better name for constant after renaming the hook 7b7df45
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 renamed template hooks 7abaeb9
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 trigger general API event for all actions 676327f
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 added general event for controllers c19465f
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 renamed some more hooks 2c5e854
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 use plural to indicate a developer can add multiple entrie…
…s or widgets
f00d2f8
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 added generic API hook cc422d3
@sabl0r sabl0r pushed a commit to sabl0r/piwik that referenced this issue
@tsteur tsteur refs #4134 renamed some more hooks and removed some not used and not …
…needed hooks
f185beb
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.